1505878 - [wpt-sync] Sync PR 13984 - Add report-only mode to Feature Policy

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13984 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13984
Details from upstream follow.

Ian Clelland <[e-mail]> wrote:
>  Add report-only mode to Feature Policy
>  
>  This change adds a "report-only" policy to each security context, which
>  is local to that context (not replicated across processes) and is used
>  to determine whether a report should be sent even if a feature is
>  enabled, when the feature is used.
>  
>  Reports are now augmented with a "disposition" field, which is either
>  "enforce", if the feature usage was actually blocked, or "report", if
>  it was not.
>  
>  Feature policy directives are placed in the report-only policy if the
>  feature name is suffixed with "-report-only", otherwise, they affect
>  the regular (enforcing) policy.
>  
>  Explainer at
>  https://github.com/WICG/feature-policy/blob/master/reporting.md
>  
>  Existing tests are updated, and new tests for report-only mode are
>  added to ensure that reports are sent even when the feature is used
>  successfully.
>  
>  Bug: 867471
>  Change-Id: I27bc42729c5ab5560160f3d993431e606a8a3a47
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1178811
>  WPT-Export-Revision: 3af1813bb06ae354e1cfc3dfc0982e9219baf6a5

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf1b0f355d3b37a56c981895bfc573ce1f2cd449

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=288e33d01453402c39b1492c9fa4e3bbfc1b9cb2

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=bcfbcd348adcbb4f99b5126b19d3e9b4d7c76252

Comment 4

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Ran 28 tests and 28 subtests
OK     : 20
FAIL   : 20
TIMEOUT: 2
ERROR  : 7
NOTRUN : 7

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/feature-policy/reporting/camera-reporting.https.html: ERROR
    Camera Report Format: NOTRUN
/feature-policy/reporting/document-write-reporting.html: ERROR
    Document-write Report Format: NOTRUN
/feature-policy/reporting/fullscreen-reporting.html
    Fullscreen Report Format: FAIL
/feature-policy/reporting/geolocation-reporting.https.html: ERROR
    Geolocation Report Format: NOTRUN
/feature-policy/reporting/microphone-reporting.https.html: ERROR
    Microphone Report Format: NOTRUN
/feature-policy/reporting/midi-reporting.html
    MIDI Report Format: FAIL
/feature-policy/reporting/payment-reporting.https.html: ERROR
    PaymentRequest Report Format: NOTRUN
/feature-policy/reporting/sync-xhr-reporting.html: ERROR
    Sync-xhr Report Format: NOTRUN
/feature-policy/reporting/vr-reporting.https.html
    VR Report Format: FAIL

New tests that have failures or other problems:
/feature-policy/reporting/camera-report-only.https.html
    Camera report only mode: FAIL
/feature-policy/reporting/document-write-report-only.html
    Document-write report only mode: FAIL
/feature-policy/reporting/encrypted-media-report-only.https.html
    Encrypted Media report only mode: FAIL
/feature-policy/reporting/fullscreen-report-only.html
    Fullscreen report only mode: FAIL
/feature-policy/reporting/generic-sensor-report-only.https.html
    Generic Sensor report only mode: FAIL
/feature-policy/reporting/geolocation-report-only.https.html: TIMEOUT
    Geolocation report only mode: TIMEOUT
/feature-policy/reporting/microphone-report-only.https.html
    Microphone report only mode: FAIL
/feature-policy/reporting/midi-report-only.html
    MIDI report only mode: FAIL
/feature-policy/reporting/payment-report-only.https.html
    PaymentRequest report only mode: FAIL
/feature-policy/reporting/picture-in-picture-report-only.html
    Picture-in-Picture Report Format: FAIL
/feature-policy/reporting/sync-xhr-report-only.html
    Sync-xhr report only mode: FAIL
/feature-policy/reporting/usb-report-only.https.html
    USB report only mode: FAIL
/feature-policy/reporting/vr-report-only.https.html
    VR report only mode: FAIL
/feature-policy/reporting/xr-report-only.https.html
    XR report only mode: FAIL

Comment 5

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=a9fbb2dab78aea3c024814539d6e07f83f42c17f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0475d6073c30
[wpt PR 13984] - Add report-only mode to Feature Policy, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/22f64d38d9c8
[wpt PR 13984] - Update wpt metadata, a=testonly

Comment 7

[Cristian Brindusan [:cbrindusan]]

Backed out 53 changesets (bug 1505878, bug 1507080, bug 1505638, bug 1507345, bug 1507122, bug 1507341, bug 1506769, bug 1497436, bug 1507796, bug 1506775, bug 1506697, bug 1507089, bug 1507908, bug 1504801, bug 1507063, bug 1507917, bug 1506089, bug 1506919, bug 1507805, bug 1507374, bug 1507421, bug 1507426, bug 1506886, bug 1488424, bug 1507558, bug 1507600, bug 1507977, bug 1507549, bug 1507526, bug 1507064, bug 1507586, bug 1508031, bug 1507472, bug 1507239, bug 1507250, bug 1507532, bug 1507519, bug 1508354, bug 1507660, bug 1506716, bug 1508014, bug 1506994) for wpt failures on grid-container-scrollbar-vertical-lr-001.html.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/46ad93280b0678c2bf9db3c3f8dcd3613b0ec9ab

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&searchStr=e39c98b6a1eae9583b521e3702e30aaf0a72c7c5&revision=584f730e1865b8dd3512ae68ac7350a9abdf07e2&selectedJob=212928785

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=212928785&repo=mozilla-inbound&lineNumber=5988

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/91431840cca3
[wpt PR 13984] - Add report-only mode to Feature Policy, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a02af0869cc
[wpt PR 13984] - Update wpt metadata, a=testonly

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/91431840cca3
https://hg.mozilla.org/mozilla-central/rev/5a02af0869cc