1506746 - Make sure we serialize the correct value at 0% or 100% during animation on rotate, translate, and scale

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Boris Chiou [:boris]]

After landing Bug 1504327, Bug 1505200, Bug 1500107, Bug 1505156, we still have some wpt failures on animation [1], and they are related to the spec issue, csswg-drafts#3290 [2]. We should resolve them after reaching the agreement on the spec issue.

Besides, there is another spec issue, csswg-drafts#3305 [3], which might be related to this.

[1] https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/css-transforms/animation
[2] https://github.com/w3c/csswg-drafts/issues/3290
[3] https://github.com/w3c/csswg-drafts/issues/3305

Comment 1

[Boris Chiou [:boris]]

This may need to update the animation code, or just update the wpt, depends on the conclusion of the spec issue.

Comment 3

[Boris Chiou [:boris]]

Both https://github.com/w3c/csswg-drafts/issues/3290 and https://github.com/w3c/csswg-drafts/issues/3305 are in agenda+, so I will try to fix this or update the wpt, based on the CSSWG decision.

Comment 4

[Boris Chiou [:boris]]

github.com/w3c/csswg-drafts/issues/3290 is resolved. We return the values the animation is working on while the animation is going.

We can update wpt in this bug to reflect the resolution.

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1506746 - Update the expected value at 0% and 100% for individual transforms.

Comment 6

[Boris Chiou [:boris]]

Attachment: Bug 1506746 - Update the expected direction vector of rotate property in wpt.

For interpolations with the primitive rotate3d(), the direction vectors of
the transform functions get normalized first. This should also be applied to
scale property.

https://drafts.csswg.org/css-transforms-2/#interpolation-of-transform-functions

Comment 7

[Boris Chiou [:boris]]

Attachment: Bug 1506746 - Update expectation for rotate property for extrapolation in wpt.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dfb29951d8b0
Update the expected value at 0% and 100% for individual transforms. r=birtles
https://hg.mozilla.org/integration/autoland/rev/3c5118f00c7c
Update the expected direction vector of rotate property in wpt. r=birtles
https://hg.mozilla.org/integration/autoland/rev/3779e7b766fd
Update expectation for rotate property for extrapolation in wpt. r=birtles

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20307 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/dfb29951d8b0
https://hg.mozilla.org/mozilla-central/rev/3c5118f00c7c
https://hg.mozilla.org/mozilla-central/rev/3779e7b766fd

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot