1585118 - Some of the rotate interpolation tests fail

Status: RESOLVED DUPLICATE of bug 1506746

(Core :: CSS Transitions and Animations, enhancement)

Description

[xidachen]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36

Steps to reproduce:

Run this test with firefox nightly:
https://github.com/web-platform-tests/wpt/blob/master/css/css-transforms/animation/rotate-interpolation.html

Actual results:

Got error message:
assert_true: 'from' value should be supported expected true got false

Expected results:

the value should be supported

Comment 1

[Florencia Di Ciocco, NI to vbalducci]

Hi,

Thanks for the test case! One question, how do you verify that you got that error? Could you send me a pic?

Thanks in advance, Flor.

Comment 2

[xidachen]

Attachment: Screenshot from 2019-10-04 09-26-39.png

Comment 3

[xidachen]

Create a local server under wpt, and open localhost:8000/css/css-transforms/animation/rotate-interpolation.html

Comment 4

[Florencia Di Ciocco, NI to vbalducci]

Hi,

Thanks for the info, it was very helpful. I've chosen a component for this bug so that the developers may look at it. We'll await their answer. If you consider that there's another component that's more proper for this case you may change it.

Regards, Flor.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Is the property enabled in your build? I get very different results if I go to about:config and set layout.css.individual-transform.enabled to true.

Xida: FYI, all WPTs are in w3c-test.org, so you could've pointed to http://w3c-test.org/css/css-transforms/animation/rotate-interpolation.html directly.

It seems we pass most of the tests there but not all. Some of them are serialization issues, like:

assert_equals: expected "45deg " but got "z 45deg "

Others seem legit like:

assert_equals: expected "- 1 1 0 60deg " but got "- 0.71 0.71 0 60deg "

Boris, you've been looking at individual transform lately, do you have cycles to look into this?

Comment 6

[Boris Chiou [:boris]]

OK. I'm looking at this.

Comment 7

[Boris Chiou [:boris]]

OK. All failures are because of https://github.com/w3c/csswg-drafts/issues/3290.
e.g.

from [45deg] to [-1 1 0 60deg] 

We promote 45deg to z 45deg for interpolation (i.e. to make sure both from and to values are 3d transform), so the serialization at 0% is z 45deg. Besides, we do normalization on the axis to make it as an unit vector, so the serialization at 100% is -0.71 0.71 0 60deg.

This is duplicated by bug 1506746.