1506988 - Don't generate change hint in AddLayerChangesForAnimation if the animation is blocked running on the compositor

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

When I woke up this morning, I noticed this fact.  And this change should fix intermittent failures bug 1506758.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34c2ceeb9262880cb80b62a49b360a00c1c9fffa

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1506988 - Skip applying change hint if we already have it in AddLayerChangesForAnimation. r?birtles!

This is just an optimization regardless of the fix improper change hint
generated by blocked animations.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1506988 - Introduce another variant of EffectCompositor::HasAnimationsForCompositor. r?birtles!

This version takes an EffectSet to avoid lookup the hashtable for the EffectSet.

The argument should be `EffectSet&` instead of `const EffectSet&` since
FindAnimationsForCompositor might call UpdateCascadeResults which mutates the
EffectSet.

Depends on D12366

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1506988 - Set the important rule change flag when a newly important rule is inserted. r?birtles!

Without this change an assertion checking IsInStyleRefresh() in
EffectCompositor::PostRestyleForAnimation will be hit when we call
FindAnimationsForCompositor from RestyleManager::DoProcessPendingRestyles
that will be introduced in a subsequent commit in this series.

I wrote a crash test which causes an assertion in KeyframeEffect::CanThrottle()
without the subsequent commit, but we need more work in display item stuff to
make the assertion won't happen (bug 1508466).

Depends on D12367

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1506988 - Don't incorporate properties that are prevented from running on the compositor in GetPropertiesForCompositor. r?birtles!

Now we no longer update the corresponding display items for the animations that
are prevented from running on the compositor if the animations themselves don't
generate any change hints, e.g the same value is specified in both 'from' and
'to' keyframes.  So that we can enable the reftests that we had been suffering
from continuous MozAfterPaint events.

Depends on D12368

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1506988 - Factor out EffectCompositor::AllowCompositorAnimationsOnFrame. r?birtles!

Now the function takes AnimationPerformanceWarning::Type* as an optional
argument for the case where we don't need to output the warning.

Depends on D12368

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1506988 - Move IsMatchForCompositor to KeyframeEffect. r?birtles!

Depends on D12396

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f111ecab40ad
Skip applying change hint if we already have it in AddLayerChangesForAnimation. r=birtles
https://hg.mozilla.org/integration/autoland/rev/6f8a7015b448
Set the important rule change flag when a newly important rule is inserted. r=birtles
https://hg.mozilla.org/integration/autoland/rev/eb0439a6c56e
Factor out EffectCompositor::AllowCompositorAnimationsOnFrame. r=birtles
https://hg.mozilla.org/integration/autoland/rev/d639382fc76a
Move IsMatchForCompositor to KeyframeEffect. r=birtles
https://hg.mozilla.org/integration/autoland/rev/fc274ec5515e
Don't incorporate properties that are prevented from running on the compositor in GetPropertiesForCompositor. r=birtles

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f111ecab40ad
https://hg.mozilla.org/mozilla-central/rev/6f8a7015b448
https://hg.mozilla.org/mozilla-central/rev/eb0439a6c56e
https://hg.mozilla.org/mozilla-central/rev/d639382fc76a
https://hg.mozilla.org/mozilla-central/rev/fc274ec5515e