1507017 - Crash in webrender::batch::AlphaBatchBuilder::add_prim_to_batch (youtube)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is
report bp-1d68fec8-1c3e-424f-81cf-7b6b70181113.
=============================================================

Seen while looking at crash stats: https://bit.ly/2FiECnD. Crashes started using 20181112220107. Looks as if maybe this was fallout due to the WR update, bug 1506494.

Top 10 frames of crashing thread:

0 xul.dll static void std::panicking::rust_panic_with_hook /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libstd/panicking.rs
1 xul.dll static void std::panicking::continue_panic_fmt /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libstd/panicking.rs:391
2 xul.dll static void std::panicking::rust_begin_panic /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libstd/panicking.rs:326
3 xul.dll static void core::panicking::panic_fmt /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libcore/panicking.rs:77
4 xul.dll static void core::panicking::panic_bounds_check /rustc/da5f414c2c0bfe5198934493f04c676e2b23ff2e/src/libcore/panicking.rs:59
5 xul.dll static void webrender::batch::AlphaBatchBuilder::add_prim_to_batch gfx/webrender/src/batch.rs:541
6 xul.dll static void webrender::batch::AlphaBatchBuilder::add_prim_to_batch gfx/webrender/src/batch.rs:1197
7 xul.dll static void webrender::batch::AlphaBatchBuilder::add_prim_to_batch gfx/webrender/src/batch.rs:1197
8 xul.dll static void webrender::tiling::{{impl}}::build gfx/webrender/src/tiling.rs:447
9 xul.dll static struct webrender::tiling::Frame webrender::frame_builder::FrameBuilder::build gfx/webrender/src/frame_builder.rs:416

=============================================================

Comment 1

[Maire Reavy [:mreavy]]

Glenn -- can you take a look?  Is it fallout from your update?

Comment 2

[Glenn Watson [:gw]]

Yep, this does appear to be caused by the patch referenced above.

I'm not sure if it's possible to fix without a repro URL, but I'll take a look today and see.

Comment 3

[Glenn Watson [:gw]]

From a manual inspection of the code, I couldn't see any obvious bugs that would cause this to occur, so we'll probably need a repro case to actually see what is happening.

Comment 4

[Marcia Knous [:marcia]]

Looks like right now, there are no URLs showing for any of the crashes. 43 crashes so far. Here are some of the addon correlations:

(56.52% in signature vs 06.88% overall) Addon "HTTPS Everywhere" = true
(47.83% in signature vs 06.87% overall) Addon "Privacy Badger" = true
(43.48% in signature vs 04.68% overall) Addon "Decentraleyes" = true
(43.48% in signature vs 05.11% overall) Addon "Reddit Enhancement Suite" = true
(39.13% in signature vs 03.41% overall) Addon "NoScript Security Suite" = true
(34.78% in signature vs 00.04% overall) Addon "Limit Tabs" = true
(34.78% in signature vs 00.23% overall) Addon "Night Mode Pro" = true
(39.13% in signature vs 04.22% overall) Addon "Greasemonkey" = true
(34.78% in signature vs 03.27% overall) Addon "NoScript Security Suite" Version = 10.1.9.9

Comment 5

[Julien Cristau [:jcristau]]

GPU process crash reports pretty much never have a URL.

Comment 6

[Gabriele Svelto [:gsvelto]]

I've just run across this signature which certainly contains some reports that correspond to this crash by looking at the stack traces:

https://crash-stats.mozilla.com/signature/?build_id=20181117220111&product=Firefox&release_channel=nightly&platform=Windows&signature=%3FMOZ_CrashOOL%40%40YAXPEBDH0%40Z.llvm.9692813384177212298&date=%3E%3D2018-11-17T03%3A00%3A00.000Z&date=%3C2018-11-19T11%3A25%3A42.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1

Unfortunately because the signature is mangled (see bug 1489094) it lumps together other crashes too.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Now that bug 1505954 is deployed the mangled signature frame shouldn't matter, since there's a sentinel frame further down the stack that we'll use to get a proper signature.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Glenn, based on comments 6 and 7 from my reading this appears that we can now get more information on this crash? If so, could you take another look at it?

Comment 9

[Glenn Watson [:gw]]

I don't think so (but could easily be misunderstanding).

All the crashes in C6 appear to be from somewhere in the moz2d blob image handler, which seem different to the crash stack above?

I don't think we have a URL / repro and I still haven't been able to repro locally yet.

Comment 10

[hgallagher]

Hi, so I was in about:support looking at 2 crashes from last night (https://crash-stats.mozilla.com/report/index/35ac902b-190f-4cbf-9175-5141c0181129 - is one of them) and found this bug report from there, this crash happens for me basically every time I try to watch this video (https://www.youtube.com/watch?v=K2IOZ-5Nk5k) in 4K 60FPS, full screen.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Also happened on https://www.youtube.com/watch?v=SjrDbSgB9IU

Comment 12

[Glenn Watson [:gw]]

I finally managed to repro this on https://www.youtube.com/watch?v=K2IOZ-5Nk5k - I am looking into it now.

Comment 13

[Josh Matthews [:jdm]]

I hit this when changing months in Google Calendar's month view.

Comment 14

[Glenn Watson [:gw]]

Fix is https://github.com/servo/webrender/pull/3436 - should make its way into the next WR update / nightly.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

This should be in the latest Nightly, can you please verify that it fixes your STR?

Comment 16

[hgallagher]

Ya this seems to have fixed it for me, I watched that video for about a minute in 4K and no crash...use to crash within a couple of seconds

Comment 17

[Kartikaya Gupta (email:[e-mail])]

Great, thanks for checking!

Comment 18

[hgallagher]

No problem, anytime :-)

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Doesn't appear to be a very high volume crash for the Beta users opted into the WR experiments. I think this can just ride the trains.