1507423 - [CSD] Titlebar has unnecessary 7px left/right border that is undraggable with light/dark theme

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Kestrel]

The #titlebar has a 7px border on the left and right side that it did not have before, particularly noticeable on maximized windows.

Ubuntu 18.10 with default Yaru theme.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fe0444b43773290c07c42ff9d648db66d28f0abd&tochange=7c2e45e82f07af5f97facb545336c4c4894c53b0

Regressed by Bug 1506248.

Comment 1

[Kestrel]

Attachment: titlebar-space.png

Comment 2

[Kestrel]

This border region is not draggable with the light/dark theme unlike the rest of the titlebar.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Yes, I can see that too. Mike, are you aware of that? Shall I look at it?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

(In reply to Martin Stránský [:stransky] from comment #3)
> Yes, I can see that too. Mike, are you aware of that? Shall I look at it?

Huh. :/ Yes, if you could look at this, that might be best. Perhaps we the solution we ended up originally is best, and we can re-land some or all of the patches that were backed out in bug 1506248?

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1507423 - Don't return border/padding from MOZ_GTK_HEADER_BAR/MOZ_GTK_HEADER_BAR_MAXIMIZED, r=mconley

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1507423 - Implement StyleAppearance::MozWindowButtonBox on widget/gtk, r=mconley

Depends on D14242

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1507423 - Don't draw StyleAppearance::MozWindowButtonBox on Linux/Gtk, r=mconley

Depends on D14243

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce0ec048b624
Don't return border/padding from MOZ_GTK_HEADER_BAR/MOZ_GTK_HEADER_BAR_MAXIMIZED, r=mconley
https://hg.mozilla.org/integration/autoland/rev/f36e19a20544
Implement StyleAppearance::MozWindowButtonBox on widget/gtk, r=mconley
https://hg.mozilla.org/integration/autoland/rev/9018fc1a4598
Don't draw StyleAppearance::MozWindowButtonBox on Linux/Gtk, r=mconley

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ce0ec048b624
https://hg.mozilla.org/mozilla-central/rev/f36e19a20544
https://hg.mozilla.org/mozilla-central/rev/9018fc1a4598

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta approval when you get a chance.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9030682 [details]
Bug 1507423 - Don't return border/padding from MOZ_GTK_HEADER_BAR/MOZ_GTK_HEADER_BAR_MAXIMIZED, r=mconley

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1506248

User impact if declined: When system titlebar is disabled, the titlebar has a 7px border on the left and right side that it did not have before, particularly noticeable on maximized windows.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: Disable system titlebar at Customize, maximize firefox window and check if there's the space between tab and firefox border:
https://bug1507423.bmoattachments.org/attachment.cgi?id=9025301

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Linux specific, live when system titlebar is disabled (this is not a default).

String changes made/needed: none

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9030683 [details]
Bug 1507423 - Implement StyleAppearance::MozWindowButtonBox on widget/gtk, r=mconley

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1506248

User impact if declined: User impact if declined: When system titlebar is disabled, the titlebar has a 7px border on the left and right side that it did not have before, particularly noticeable on maximized windows.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: Disable system titlebar at Customize, maximize firefox window and check if there's the space between tab and firefox border:
https://bug1507423.bmoattachments.org/attachment.cgi?id=9025301

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Why is the change risky/not risky? (and alternatives if risky): Linux specific, live when system titlebar is disabled (this is not a default).

String changes made/needed: none

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9030684 [details]
Bug 1507423 - Don't draw StyleAppearance::MozWindowButtonBox on Linux/Gtk, r=mconley

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1506248

User impact if declined: User impact if declined: When system titlebar is disabled, the titlebar has a 7px border on the left and right side that it did not have before, particularly noticeable on maximized windows.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: Disable system titlebar at Customize, maximize firefox window and check if there's the space between tab and firefox border:
https://bug1507423.bmoattachments.org/attachment.cgi?id=9025301

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Why is the change risky/not risky? (and alternatives if risky): Linux specific, live when system titlebar is disabled (this is not a default).

String changes made/needed: none

Comment 14

[Peter Magyari (Desktop QA)]

Verified as fixed on Firefox Nightly 66.0a1 (2018-12-21) on Ubuntu 18.10 (64-bit).

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9030682 [details]
Bug 1507423 - Don't return border/padding from MOZ_GTK_HEADER_BAR/MOZ_GTK_HEADER_BAR_MAXIMIZED, r=mconley

[Triage Comment]
Removes extra padding from the tab bar when the system titlebar is disabled on Linux. Approved for 65.0b7.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/08d3a2f3dfd4
https://hg.mozilla.org/releases/mozilla-beta/rev/c251f26c00d2
https://hg.mozilla.org/releases/mozilla-beta/rev/171e95e6389b

Comment 17

[Anca Soncutean, Desktop QA]

I can confirm also the fix on Beta, I’ve tested with Fx 65.0b7 (20181223195937) on Ubuntu 18.04.1 X64.