1507484 - Implement minimal Ion support for BigInt

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Andy Wingo [:wingo]]

Bug 1505849 lands some beginnings of JIT support for BigInt, but there are still failures:

$ ../js/src/tests/jstests.py dist/bin/js non262/reflect-parse/expression.js
## non262/reflect-parse/expression.js: rc = -11, run time = 0.102644
Hit MOZ_CRASH(Unexpected type) at /home/wingo/src/mozilla-inbound/js/src/jit/CacheIRCompiler.cpp:1686
REGRESSION - non262/reflect-parse/expression.js
[0|1|0|0] 100% ==========================================================>|   0.5s
REGRESSIONS
    non262/reflect-parse/expression.js
FAIL

Instead of fixing these problems in that bug, let's fix in a follow-up.

Comment 1

[Robin Templeton [:terpri]]

Attachment: Bug 1507484 - Implement minimal Ion support for BigInt

Rough draft of Ion support for BigInt values

Comment 2

[Robin Templeton [:terpri]]

Attachment: arcpatch-D14826-range-diff.txt

git range-diff for phabricator updates from diff #8 to diff #12

Comment 3

[Robin Templeton [:terpri]]

try run for jsreftest and jittests on all platforms: https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc06acdbb18b79e65afb294fafb14d42e6b23596

Comment 4

[Cosmin Sabou [:CosminS]]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpOEXy_8\npatching file js/src/jit/arm64/CodeGenerator-arm64.cpp\nHunk #1 FAILED at 811\n1 out of 3 hunks FAILED -- saving rejects to file js/src/jit/arm64/CodeGenerator-arm64.cpp.rej\npatching file js/src/jit/MacroAssembler.cpp\nHunk #1 FAILED at 100\n1 out of 2 hunks FAILED -- saving rejects to file js/src/jit/MacroAssembler.cpp.rej\npatching file js/src/jit/CodeGenerator.cpp\nHunk #11 FAILED at 11731\n1 out of 12 hunks FAILED -- saving rejects to file js/src/jit/CodeGenerator.cpp.rej\nabort: patch failed to apply', '')

Comment 5

[Robin Templeton [:terpri]]

i rebased the last diff to include formatting changes from bug 1519636; it should be ready to land now

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=43b7752940772ef8f4c5217c45a06c9f9bddfe22

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf113c9d6075
Implement minimal Ion support for BigInt r=wingo,jandem

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/cf113c9d6075

Comment 8

[Andy Wingo [:wingo]]

Changed ff66 status to disabled because it's behind ENABLE_BIGINT which is off in ff66.