Closed Bug 1507709 Opened 2 years ago Closed 1 year ago
Profiler API to toolkit
47 bytes, text/x-phabricator-request
|Details | Review|
The browser.geckoProfiler API is in browser/components/extensions, but it seems to me none of the code there depends on a Firefox feature. I'd like to move this code to toolkit, so that Thunderbird can also profit from it. Not quite done yet, but the try run seems to be passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e4d489ba70d813d69918172cfaae7293f5ecead I've also done a brief test of the gecko profiler add-on in the resulting build.
Hmm, a process crash on Android. Any ideas how to debug this without an Android device? Or does Android just not support the profiler and I should turn off those tests?
You could use an emulator if you don't have a physical device. See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build
(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #2) > Hmm, a process crash on Android. Any ideas how to debug this without an > Android device? Or does Android just not support the profiler and I should > turn off those tests? I don't think your patch changes anything that might trigger this crash, so it's probably an existing crash that would also happen without your patch. It only happens on the "Android 4.2 opt x86" platform, and looking at a mozilla-central job such as https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=android%2C4.2%2Copt&revision=24e87b02707bee36e1e98eb37c94fbaf3834e898 , it looks like none of the X jobs on that platform currently run the test_ext_geckoProfiler_control.js test. I don't know why that is. So let's just disable the test on Android x86 for now.
(In reply to Markus Stange [:mstange] from comment #4) > , it looks like none of the X jobs on that platform currently run the > test_ext_geckoProfiler_control.js test. I don't know why that is. > So let's just disable the test on Android x86 for now. Thanks for digging into this Markus! test_ext_geckoProfiler_control.js was previously in browser/ so I am not surprised this test did not run previously. I moved all the tests over because the point of this bug is to make browser.geckoProfiler available to all gecko apps, which also includes Firefox for Android. I'm happy to disable the test for now though, I'll add a comment referencing bug 1510301.
>>! In D12100#357139, @kmag wrote: > I'm fine with moving this to toolkit, but we need to make sure we don't package it in places where it's not supported. My understanding is that this is generally supported under Android, but bug 1510301 is causing a crash under certain circumstances. I'm not sure how to not package this in Android aside from moving the ext-toolkit.json to ext-browser.json/ext-mail.json but referencing the toolkit files. Is that what you were intending? Or can we leave it in ext-toolkit and assume that Android folks will fix the crash instead?
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/2a4bddaaf3dc Move WebExtensions geckoProfiler API to toolkit. r=kmag
You need to log in before you can comment on or make changes to this bug.