1538592 - Make geckoProfiler work in Thunderbird

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/components/extensions/test/xpcshell/test_ext_geckoProfiler_schema.js | Test timed out

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=59e55930dc0f243357a8730be1a0ca372e&tochange=8941a9be9141409229814e2688d207a890

Looks like bug 1507709 caused that. Geoff, can you please take a look.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1538592-profiler-1.diff

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6af3543d4d15
Make Gecko Profiler available to WebExtensions; rs=bustage-fix

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9053176 [details] [diff] [review]
1538592-profiler-1.diff

Review of attachment 9053176 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, we need to add one more patch I'll post in a minute.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Add acceptedExtensionIds - v1

Comment 5

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/comm-central/rev/21553a9210969428480fe904869d5f101a2ca121

Comment 6

[llrraa]

Yesterday I tried to start the performance profiler, but failed to Capture Profile, and ctrl+shift+2 is not working either. Please help.

Application Basics

Name: Thunderbird
Version: 72.0a1
Build ID: 20191104093451

Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:72.0) Gecko/20100101 Thunderbird/72.0a1
OS: Windows_NT 6.1

Launcher Process: Enabled
Multiprocess Windows: 0/0
Disabled
Remote Processes: 0
Enterprise Policies: Inactive
Google Location Service Key: Missing
Google Safebrowsing Key: Missing
Mozilla Location Service Key: Missing
Safe Mode: false

Comment 7

[llrraa]

I try to start the Gecko Profiler(buffer size: 90MB), and Capture Profile without doing anything, it does open a new tab and try to grab the profile, but it fails with the following hint:
We were unable to connect to the Gecko profiler add-on within thirty seconds. This might be because the profile is big or your machine is slower than usual. Still waiting...

Should I report a new bug for this?

Comment 8

[Geoff Lankow (:darktrojan)]

These days the profiler can be accessed in the developer toolbox without any add-ons. (You need to go to the toolbox settings to make it visible.)

Comment 9

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

The Gecko Profiler is actually a bit different than the built in profiler. If it is not working there is likely a bug, but we'll need a new one for that. Please check if there are maybe other error messages.

Comment 10

[llrraa]

(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #9)

The Gecko Profiler is actually a bit different than the built in profiler. If it is not working there is likely a bug, but we'll need a new one for that. Please check if there are maybe other error messages.

Yes, I manage to activate the built in profiler, and save the result to a json file. But when I try to upload it to https://profiler.firefox.com/, it returns with the Error: Unserializing the profile failed: TypeError: Cannot read property 'version' of undefined.
I don't know how to get other error messages if there are any. So please help.

Comment 11

[llrraa]

Attachment: profile191125.json, profile from the built in profiler

profile191125.json is the profile from the built in profiler.