1507755 - Switch to Tab does not always switch to tab

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, defect, P3)

Description

[Mikael Håkansson]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

1. Open "https://www.reddit.com/r/firefox/". (Not reproducible with "https://www.reddit.com/r/firefox".)

2. Copy full URL from address bar.

3. Open new tab and paste URL into address bar.

4. Press down until you get to "Switch to Tab" and press enter.


Actual results:

URL is loaded/opened in current tab.


Expected results:

That Firefox switches to tab that is already open.

Comment 1

[Mikael Håkansson]

The behaviour changes depending on if the URL end with a "/" or not.

For URLs not ending with a "/" (e.g. "https://www.reddit.com"), step 4 would be (does not work on "https://www.reddit.com/r/firefox"):

4. Press down until you get to "Switch to Tab", write "/" and press enter.

Another way to reproduce (again, does not work with "https://www.reddit.com/r/firefox"):

1. Open "https://www.reddit.com".
2. Open new tab and write reddit.
3. Press down to "Switch to Tab" entry.
4. Write "/". (Switch to Tab no longer selected. Top one "visit" is automatically selected)
5. Press down to the "Switch to Tab" entry again.
6. Write "/". (Switch to Tab is still selected)
7. Press Enter.

Does not switch to tab, opens in current tab as if visit is selected.

I see the same behaviour on Windows 10 with both 63.0.1 and 65.0a1.

Comment 2

[Marco Bonardo [:mak]]

Interesting, I wonder if this is a regression, we should investigate this.

Comment 3

[Mikael Håkansson]

I ran mozregression-gui, first time so tell me if you need additional information.

Last good: build_date: 2018-05-14 22:56:30.487000
First bad: build_date: 2018-05-15 00:00:09.208000

DEBUG : Found commit message:
Bug 1239708: Improve awesomebar autofill. Part 6: Browser tests. r=mak

MozReview-Commit-ID: 7r62byWErUS

Comment 4

[Marco Bonardo [:mak]]

Thanks, we'll investigate.

Comment 5

[Drew Willcoxon :adw]

Isn't this bug 1349716?

Comment 6

[Marco Bonardo [:mak]]

(In reply to Drew Willcoxon :adw from comment #5)
> Isn't this bug 1349716?

Or maybe that bug was indeed fixed and this is a new regression... considered the age I'd prefer to close that one and keep this one regardless. We also have a regrange here.

Comment 7

[Drew Willcoxon :adw]

Copying these comments here in case they're useful:

(In reply to Drew Willcoxon :adw from bug 1349716 comment #6)
> Did some debugging -- when handleCommand is
> called due to a click, this.value is correctly a switchtab action URL.  But
> when it's called due to an enter keypress, this.value is the plain URL of
> the switch-to-tab tab.  It may have something to do with our deferred enter
> keypress handling, but I don't immediately see how.

(In reply to Drew Willcoxon :adw from bug 1349716 comment #7)
> ... or the nsAutoCompleteController.cpp changes in
> https://hg.mozilla.org/mozilla-central/rev/c35d8f056f67 which Alice narrowed
> down in comment 1.

Comment 8

[Marco Bonardo [:mak]]

So, what we see in the Quantum Bar is bug 1531327, not this one, that AFAICT is fixed in the Quantum Bar (I can't reproduce it there).
So I'll work on that one instead.

Comment 9

[Arpit Bharti]

I'm interested in working on this issue.

Comment 10

[Marco Bonardo [:mak]]

I am adding a test in bug 1531327 that will be disabled until this is fixed, so it can be used to check the fix. Though, notice the fix here may not be trivial at all, it involves working with some legacy cpp code that has lots of possible implications.
I'd rather suggest looking into bugs at https://codetribute.mozilla.org

Comment 11

[Arpit Bharti]

(In reply to Marco Bonardo [::mak] from comment #10)

I am adding a test in bug 1531327 that will be disabled until this is fixed, so it can be used to check the fix. Though, notice the fix here may not be trivial at all, it involves working with some legacy cpp code that has lots of possible implications.
I'd rather suggest looking into bugs at https://codetribute.mozilla.org

Thanks for your suggestions.
I messed around with the address bar code and this does seem too difficult for someone new to firefox development.

Comment 12

[Marco Bonardo [:mak]]

the browser_switchToTab_fullUrl_repeatedKeydown.js has been enabled, thus I guess this was fixed alogn the way?

Comment 13

[Mikael Håkansson]

I can no longer reproduce this bug in either 82.0.2 or Nightly, so I consider it fixed.

Comment 14

[Marco Bonardo [:mak]]

Thanks for reporting back