1531327 - [Search Quantumbar] Releasing the shift key doesn't reactivate the switch to tab option in search suggestions

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[laszlo.bialis]

Note

• Make sure "browser.urlbar.quantumbar" is set to "true" in about:config

Affected versions

• Nightly 67.0a1

Affected platforms

• Only Windows, tried on Win10 & Win7 x64
  macOS 10.14 and Ubuntu 16.04 don't reproduce this issue

Steps to reproduce

1. Launch Firefox
2. Search for ex: youtube from the URL bar
3. Leave the tab with the search results open
4. Open a new tab and search again for youtube
5. After the search suggestions are displayed check for the "Switch to tab" suggestion
6. Press and release Shift key

Expected result

• When Shift key is pressed the "Switch to tab" suggestion should disappear, instead a link should be displayed. After Shift key is released the "Switch to tab" suggestion should be displayed again.

Actual result

• After releasing the Shift key the "Switch to tab" suggestion is not displayed anymore, as the key would remain pressed. Pressing the Shift key several times again would not change this behavior, only open the Sticky Keys popup. Even if one selects not to activate Sticky Keys from the popup, the "Switch to tab" suggestion wouldn't be shown again.

Additional notes

• I've reproduced this issue every time on a regularly used profile, with rich history.
• On a new profile however the issue is reproduced intermittently, only after several tries with the press and release Shift key combination I've managed to reproduce it.

Comment 1

[Marco Bonardo [:mak]]

I cannot directly reproduce the bug with the given steps... but I think I know what's up. Basically the Event Bufferer delays the events, but we use those events to track override keys like SHIFT. If a keydown is delayed, the keyup may happen before it is replayed. The old implementation didn't suffer this problem because it was delaying keypress and using keydown to track override keys.

Comment 2

[Marco Bonardo [:mak]]

I'll have to change the way the EventBufferer hooks into input.

Comment 3

[Marco Bonardo [:mak]]

And the other problem is that on Windows the keydown event gets repeated if you keep the button pressed, other platforms may differ. Thus we can't just use a counter.

Comment 4

[Marco Bonardo [:mak]]

Attachment: Bug 1531327 - Properly handle actions overrides in the Quantum Bar. r=Standard8!

This fixes 2 problems causing overrides (with SHIFT/ALT/CTRL) to stick longer than expected:

1. The event bufferer may delay keydown, keyup could then happen before it
2. On some platforms holding a key generates multiple events, so there's no match in number of keydown/keyup

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9e6f5d564be
Properly handle actions overrides in the Quantum Bar. r=dao

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d9e6f5d564be