1508096 - Crash in mozilla::wr::ImageDescriptor::ImageDescriptor | MOZ_RELEASE_ASSERT(mIsSome)

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Bob Clary [:bc] (inactive)]

This bug was filed from the Socorro interface and is
report bp-597be6af-40a8-4eee-9c47-915cf0181117.
=============================================================

Top 10 frames of crashing thread:

0 libxul.so mozilla::wr::ImageDescriptor::ImageDescriptor mfbt/Maybe.h:518
1 libxul.so mozilla::layers::BufferTextureHost::PushResourceUpdates gfx/layers/composite/TextureHost.cpp:651
2 libxul.so mozilla::layers::AsyncImagePipelineManager::UpdateImageKeys gfx/layers/wr/AsyncImagePipelineManager.cpp:319
3 libxul.so mozilla::layers::AsyncImagePipelineManager::ApplyAsyncImageForPipeline gfx/layers/wr/AsyncImagePipelineManager.cpp:399
4 libxul.so mozilla::layers::AsyncImagePipelineManager::ApplyAsyncImageForPipeline gfx/layers/wr/AsyncImagePipelineManager.cpp:502
5 libxul.so mozilla::layers::WebRenderBridgeParent::ProcessWebRenderParentCommands mfbt/RefPtr.h
6 libxul.so mozilla::layers::WebRenderBridgeParent::RecvSetDisplayList gfx/layers/wr/WebRenderBridgeParent.cpp:935
7 libxul.so mozilla::layers::PWebRenderBridgeParent::OnMessageReceived ipc/ipdl/PWebRenderBridgeParent.cpp:403
8 libxul.so mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2244
9 libxul.so mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:2008

=============================================================

1. open https://www.nytimes.com/interactive/2018/11/15/climate/yellowstone-global-warming.html in a private browsing window in Firefox Nightly Linux x86_64.

2. scroll down via the mouse wheel.

3. MOZ_RELEASE_ASSERT(mIsSome)

I started seeing this crash on 11/16 on a google maps page.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Must be crashing here: https://searchfox.org/mozilla-central/rev/5117a4c4e29fcf80a627fecf899a62f117368abf/gfx/webrender_bindings/WebRenderTypes.h#124 with some unsupported format.

Comment 2

[Laurențiu Nicola]

This also seems to happen on any PDF opened in Firefox.

Comment 3

[Ludovic Hirlimann [:Usul]]

My FB feed - who tries to display one of these 360° pictures

Comment 4

[Sotaro Ikeda [:sotaro]]

I tried comment 0 and comment 2 on Ubuntu. But I did not saw the crash.

This problem might be similar to Bug 1482350.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)
> I tried comment 0 and comment 2 on Ubuntu. But I did not saw the crash.
> 
> This problem might be similar to Bug 1482350.

When I enabled wayland on Ubuntu. I hit the crash on nightly.

Comment 6

[Sotaro Ikeda [:sotaro]]

:bc:, is wayland enabled on your pc?

Comment 7

[Bob Clary [:bc] (inactive)]

Yes gdm-wayland and Xwayland are running in Gnome 3.30, though I haven't enabled the wayland feature in Firefox.

Comment 9

[Marco Castelluccio [:marco]]

I can reproduce the crash as soon as I load Google Maps. Same situation as :bc regarding Wayland.

Comment 10

[Sotaro Ikeda [:sotaro]]

This seems to be related.
  https://groups.google.com/forum/#!topic/mozilla.dev.platform/e1gehMgXwHI

Comment 11

[Asif Youssuff]

Crashes for me soon after beginning to load https://floooh.github.io/tiny8bit/kc85.html?type=kc85_3&snapshot=kc85/breakout.kcc&input=BREAKOUT%0A

Wayland (GNOME) session, but not natively using Wayland for Firefox. 

Regression window seems to be:

12:46.03 INFO: Narrowed inbound regression window from [e762fce8, 6eb370cb] (3 builds) to [e762fce8, 6fc6bdea] (2 builds) (~1 steps left)
12:46.03 INFO: No more inbound revisions, bisection finished.
12:46.03 INFO: Last good revision: e762fce85daa2b0399f443c4644c6e61a11b1eb3
12:46.03 INFO: First bad revision: 6fc6bdea42a60b7e3fb426beb073e07a3922913c
12:46.03 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e762fce85daa2b0399f443c4644c6e61a11b1eb3&tochange=6fc6bdea42a60b7e3fb426beb073e07a3922913c

Comment 12

[Sotaro Ikeda [:sotaro]]

:bc:, is the crash addressed with latest nightly?

Comment 13

[Bob Clary [:bc] (inactive)]

I haven't seen this recently. Attempting my original str does not reproduce nor does the floooh url with this evening's build 20181128220334.

Comment 14

[Asif Youssuff]

FWIW, loading https://floooh.github.io/tiny8bit/kc85.html?type=kc85_3&snapshot=kc85/breakout.kcc&input=BREAKOUT%0A in the latest nightly is also working for me now.

Comment 15

[Sotaro Ikeda [:sotaro]]

It works also for me. I am going to close this bug.

Comment 16

[Sotaro Ikeda [:sotaro]]

Thanks!

Comment 17

[Laurențiu Nicola]

This still happens for me when opening PDFs with WR enabled (Linux x64 XWayland).

Comment 18

[Sotaro Ikeda [:sotaro]]

(In reply to Laurentiu Nicola from comment #17)
> This still happens for me when opening PDFs with WR enabled (Linux x64
> XWayland).

Laurentiu Nicola, can you create a new bug for it? It seems like a different bug.

Comment 19

[Laurențiu Nicola]

Are you sure that's a good idea? I came here from the crash report page, since it's the same signature:

https://crash-stats.mozilla.com/report/index/be4ed823-4222-4246-b40b-835db0181212#tab-details

It's also happening for others:

https://crash-stats.mozilla.com/signature/?product=Firefox&signature=mozilla%3A%3Awr%3A%3AImageDescriptor%3A%3AImageDescriptor&date=%3E%3D2018-12-05T22%3A52%3A48.000Z&date=%3C2018-12-12T22%3A52%3A48.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_sort=-date&page=1#reports

Comment 20

[Sotaro Ikeda [:sotaro]]

(In reply to Laurentiu Nicola from comment #19)
> Are you sure that's a good idea? I came here from the crash report page,
> since it's the same signature:
> 

This bug added RGBA support. The remaining crash seems to be caused by another color format support like RGBX.