1508608 - [Wayland][touch] Addon popups and context menus do not close when clicked away using touch controls

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Oto Šťáva]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

In Firefox on Wayland on Fedora 29, I opened an addon popup in the top panel using touch controls / opened a context menu by touch-and-hold. Then I tried to close said popup/menu by touching outside of its region.


Actual results:

The popup/menu did not hide.


Expected results:

The popup/menu should close upon touching outside of its region, just like it does with mouse clicks or under X11/XWayland.

Comment 1

[russianneuromancer]

Issue is still reproducible on Firefox Nightly 68.0a1 (2019-04-04).

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1552613

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I can repro this, fwiw.

Comment 5

[Alexander Kempen]

I can also still reproduce this with 79.0 and Nightly.

Comment 6

[Alexander Kempen]

Still the same in 81.0.

Comment 7

[Ari]

Setting xul.panel-animations.enabled to true fixes this issue for me and also adds the nice animations from the Windows version of FF.

But there is a small issue as a result:
Having an addon window open and trying to open another addon window can cause odd animation canceling behavior and in rare instances cause FF to freeze.

Comment 8

[chron]

Interesting, changing xul.panel-animations.enabled to true does not change anything for me.

Comment 9

[Ari]

(In reply to chron from comment #8)

Interesting, changing xul.panel-animations.enabled to true does not change anything for me.

I misread the initial issue. This fixes an unrelated problem I've had with FF for Wayland. Sorry for the confusion.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Can you please test latest nightly under Wayland? A new popup handling code landed there.
Thanks.

Comment 12

[Jan Alexander Steffens [:heftig]]

Still broken as of https://hg.mozilla.org/mozilla-central/rev/5d03a9d6cb8aeba1bb488b989712ad9cfa0546d2

Comment 13

[Elia Devito]

Fixed in latest nightly have tested last nightly on Fedora 34 Workstation and the problem seem fixed.

NB: ho lanciato firefox con MOZ_USE_XINPUT2=1

Comment 14

[Elia Devito]

(In reply to Elia Devito from comment #13)

Fixed in latest nightly have tested last nightly on Fedora 34 Workstation and the problem seem fixed.

NB: ho lanciato firefox con MOZ_USE_XINPUT2=1

sorry I sent the message by mistake, the bug is still here

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Please re-test with new nightly as it gets another popup fixes.
Thanks.

Comment 16

[Strangiato]

Still reproducible with latest nightly build.

Comment 18

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1508608 [Linux] Check for Rollup events at nsWindow::OnTouchEvent/GDK_TOUCH_BEGIN, r?botond

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a0cc6cf8702
[Linux] Check for Rollup events at nsWindow::OnTouchEvent/GDK_TOUCH_BEGIN, r=botond

Comment 20

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0a0cc6cf8702