1508853 - Post install panel hides search opt-in panel

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[Deepak]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.102 Safari/537.36

Steps to reproduce:

Do inline install of Extension that requires Search Override permission. Users have to opt-in for the permission after extension is installed. 

This is based of changes introduced for "Installation notification Prompt" described here https://blog.mozilla.org/addons/2018/11/08/extensions-in-firefox-64/


Actual results:

After extension is installed users get prompted with 2 notifications.
1. Opt-in for Search override permission
2. Installation notification Prompt

When user click on "OK" for Installation notification Prompt the Opt-in Permission automatically hides not giving users opportunity to take action.


Expected results:

Similar to addon installation experience in AMO Store users should be prompted for "Opt-In" Permission first and based on user action "Installation notification Prompt" should follow.

Comment 1

[Mike Kaply [:mkaply]]

Please provide an example of an add-on on AMO that has this issue.

Comment 2

[Deepak]

Shane, 

I am using nightly build 65.0a1 (2018-11-26) (64-bit)on Mac.

1. Addon published in AMO- https://addons.mozilla.org/en-US/firefox/addon/jobsrch/?src=search
2. Self hosted Addon distributed from - http://jobsrch.org/

Thanks,
Deepak

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: InstallPanels.png

The quick and simple fix is to change the persistent value to true.  This however results in the attached image.

https://searchfox.org/mozilla-central/rev/d35199ef15ffa57d190886e20d5df6471faf0870/browser/modules/ExtensionsUI.jsm#368

Comment 4

[Shane Caraveo (:mixedpuppy)]

Also of note, this only affects search providers that set is_default: true in the manifest.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1508853 make the search default panel persistent, r?aswan

This is a quick fix to ensure that the search install panel is shown when an extension uses is_default.  The intention is to uplift for 64.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d40fbd0c1a77
make the search default panel persistent, r=aswan

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d40fbd0c1a77

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

We're building the last 64 beta today, please request uplift asap.

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9027919 [details]
Bug 1508853 make the search default panel persistent, r?aswan

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Users installing some search extensions will not get the panel asking about default setting

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: Yes

If yes, steps to reproduce: see original comment for STR

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is simply changing a boolean value for the search opt-in panel.  we have followup bugs to improve on the UI issues, this just makes it possible for the user to react to the panel.

String changes made/needed: none

Comment 10

[CosminB]

Attachment: Bug1508853.zip

I was able to reproduce this issue on Firefox 64.0b13(20181126173133) under Win7 64-bit and Mac OS 10.13.6.

On Firefox 65.0a1(20181128100125) under Win7 64-bit and Mac OS 10.13.6 I have the next scenarios:

For http://jobsrch.org/ the Search override permission is persistent with the confirmation pop-up but I have the next behaviors: 

- Clicking on the “OK” button from the confirmation pop-up will continue to display the Search override permission. 

- Switching the tab with the two pop-ups displayed, will display only the confirmation pop-up and dismiss the Search override permission. (Not sure about this one)

For https://addons.mozilla.org/en-US/firefox/addon/jobsrch/?src=search the Search override permission is displayed first and only after clicking “Yes” or “No” the confirmation pop-up is displayed. (Not sure about this one)

Also, if I switch the tab with the two pop-ups displayed, the Search override permission is dismissed and the confirmation pop-up is persistent. (Not sure about this one)

Are these the expected behaviors for this fix?

Comment 11

[CosminB]

> Also, if I switch the tab with the two pop-ups displayed, the Search
> override permission is dismissed and the confirmation pop-up is persistent.
> (Not sure about this one)

Please ignore this part from my previous comment, this behavior does not exist for the AMO scenario.

Comment 12

[Shane Caraveo (:mixedpuppy)]

Switching tabs will dismiss the search prompt, that is expected behavior and is the same as before.

The post-install confirmation (off the menu button) is expected to be persistent until the user clicks it, regardless of tab/window switching.  The search prompt (off the url bar) is tab-modal and is dismissed if you switch tabs (and I think, if you switch windows), click anywhere else, etc.

Comment 13

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9027919 [details]
Bug 1508853 make the search default panel persistent, r?aswan

fix a regression in 64, per conversation with Shane the verification in nightly yields expected results; approved for 64.0b14

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/fa72e773a9eb

Comment 15

[CosminB]

Thank you Shane!

According to Comment 11 and Comment 12, this issue is verified as fixed.

Comment 16

[CosminB]

This issue is also verified as fixed on Firefox 64.0b14 (20181128185223) under Win7 64-bit and Mac OS X 10.13.6