1510097 - Move bootstrapped extension and install.rdf handling to comm-central

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1510097-bootstrapped-move-1.diff

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1510097-diff-1.diff

These are the differences between the files I've copied from mozilla-central (after part 3 of bug 857456), and how they are now.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9028476 [details] [diff] [review]
1510097-bootstrapped-move-1.diff

There's a few new things in here that don't show up in the other diff.

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 9028476 [details] [diff] [review]
1510097-bootstrapped-move-1.diff

Review of attachment 9028476 [details] [diff] [review]:
-----------------------------------------------------------------

You really jumped right in!  Note that some things got renamed in the patches on bug 857456, sorry if it wasn't clear that those were works-in-progress that might change before landing.

Comment 5

[Geoff Lankow (:darktrojan)]

Well, having this stuff working is rather important to us. Half of our tests die if it isn't. Now that I've figured out all the issues, rebasing should be easy enough.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1510097-bootstrapped-move-2.diff

This must land with the next inbound-to-central merge or Mozmill will die a horrible death.

Comment 7

[Geoff Lankow (:darktrojan)]

Attachment: 1510097-diff-2.diff

Same as before, the difference between part 3 of bug 857456 and this bug. Probably not much use any more, but here we are.

Comment 8

[Jorg K (CEST = GMT+2)]

(In reply to Geoff Lankow (:darktrojan) from comment #6)
> This must land with the next inbound-to-central merge or Mozmill will die a
> horrible death.
It wouldn't be the first time it stopped working for a while, like when non-bootstrapped extensions stopped working and we made MozMill and JS Bridge bootstrapped in a hurry. That said, I'll land it.

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9028796 [details] [diff] [review]
1510097-bootstrapped-move-2.diff

Review of attachment 9028796 [details] [diff] [review]:
-----------------------------------------------------------------

::: common/src/BootstrapLoader.jsm
@@ +1,1 @@
> +

has a blank line on top. but, should add the MPL notice

::: common/test/xpcshell/data/BootstrapMonitor.jsm
@@ +1,1 @@
> +ChromeUtils.import("resource://gre/modules/Services.jsm");

this file too should have a license

::: common/test/xpcshell/head_addons.js
@@ +690,5 @@
> +                 actualValue.toSource() + ")");
> +      }
> +
> +      return;
> +    } else if (expectedValue && !actualValue) {

no else after return

@@ +1249,5 @@
> +Services.prefs.setBoolPref(PREF_XPI_SIGNATURES_REQUIRED, false);
> +
> +Services.prefs.setBoolPref("extensions.legacy.enabled", true);
> +
> +

extra blank line

@@ +1279,5 @@
> +  };
> +}
> +
> +/**
> + * Change the schema version of the JSON extensions database

these documentations could add a period at the end

::: common/test/xpcshell/test_bootstrap.js
@@ +31,5 @@
> +userExtDir.append("extensions2");
> +userExtDir.append(gAppInfo.ID);
> +registerDirectory("XREUSysExt", userExtDir.parent);
> +
> +

extra blank line

@@ +154,5 @@
> +  }
> +  equal(data.size, 0);
> +}
> +
> +

and here

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9028797 [details] [diff] [review]
1510097-diff-2.diff

Review of attachment 9028797 [details] [diff] [review]:
-----------------------------------------------------------------

This is toolkit/ - someone from there should review

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9a6732b236da
Move bootstrapped extension and install.rdf handling to comm-central. r=mkmelin

Comment 12

[Jorg K (CEST = GMT+2)]

That was just a *total success* !! \o/

Comment 13

[Geoff Lankow (:darktrojan)]

Yes, thank you Andrew, for making that process so easy.

Comment 14

[Andrew Swan [:aswan]]

Cheers, I'm glad to hear that...

Comment 15

[Axel Grude [:realRaven]]

Is there a way to load restartless Add-ons in Tb69? it appears that version requires manifest.json, but adding the file breaks it too.

When trying to install the restartless Add-on with only install.rdf Tb 69 says "This add-on could not be installed because it is not compatible with Daily 69.0a1" - no such problem with conventional legacy Add-ons.

<em:targetApplication>
  <Description>
    <em:id>{3550f703-e582-4d05-9a08-453d09bdfdc6}</em:id>
    <em:minVersion>60.0</em:minVersion>
    <em:maxVersion>69.0a1</em:maxVersion>
  </Description>
</em:targetApplication>

Comment 16

[Geoff Lankow (:darktrojan)]

Please see this maildev post and this updated documentation.