Maybe exclude irregexp from reformatting

RESOLVED FIXED in Firefox -esr60

Status

defect
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: Ehsan, Assigned: sylvestre)

Tracking

(Blocks 2 bugs)

Trunk
mozilla65
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

7 months ago
Given the existence of bug 1367105 and pending patches in there, does it make sense for us to reformat this directory right now, or should it be added to .clang-format-ignore to avoid disrupting that work in progress?
Flags: needinfo?(jorendorff)
It should definitely be excluded. Good eye, I would not have remembered this in time.
Flags: needinfo?(jorendorff)
Assignee

Updated

7 months ago
Assignee: nobody → sledru
I opened Bug 1507887 for this, but didn't get a reply from :anba yet. I think it should be fine to ignore all of js/src/irregexp, but to format js/src/builtin/RegExp*
Blocks: 1508062

Comment 4

7 months ago
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca2e3366674c
Exclude irregexp from reformatting r=Ehsan

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ca2e3366674c
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Blocks: 1510535
Reporter

Comment 6

6 months ago
Comment on attachment 9027879 [details]
Bug 1510128 - Exclude irregexp from reformatting r?ehsan

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB

String or UUID changes made by this patch: None
Attachment #9027879 - Flags: approval-mozilla-esr60?
Comment on attachment 9027879 [details]
Bug 1510128 - Exclude irregexp from reformatting r?ehsan

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9027879 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.