Closed Bug 1510128 Opened 5 years ago Closed 5 years ago

Maybe exclude irregexp from reformatting

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr60 fixed, firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1510128 - Exclude irregexp from reformatting r?ehsan
47 bytes, text/x-phabricator-request
lizzard
: approval-mozilla-esr60+
Details | Review 
Given the existence of bug 1367105 and pending patches in there, does it make sense for us to reformat this directory right now, or should it be added to .clang-format-ignore to avoid disrupting that work in progress?
Flags: needinfo?(jorendorff)
It should definitely be excluded. Good eye, I would not have remembered this in time.
Flags: needinfo?(jorendorff)
Assignee: nobody → sledru
I opened Bug 1507887 for this, but didn't get a reply from :anba yet. I think it should be fine to ignore all of js/src/irregexp, but to format js/src/builtin/RegExp*
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ca2e3366674c
Exclude irregexp from reformatting r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/ca2e3366674c
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Blocks: 1510535
Comment on attachment 9027879 [details]
Bug 1510128 - Exclude irregexp from reformatting r?ehsan

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB

String or UUID changes made by this patch: None
Attachment #9027879 - Flags: approval-mozilla-esr60?
Comment on attachment 9027879 [details]
Bug 1510128 - Exclude irregexp from reformatting r?ehsan

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9027879 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Target Milestone: Firefox 65 → mozilla65
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.