1510266 - reply/forward etc buttons in mail header no longer shown using View | Headers | All

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Alice0775 White]

Attachment: screenshot 63 vs 64

Steps To reproduce:
1. Receive a HTML mail contains images
2. Select the mail in the list view
3. View > Headeres > All

Actual Results:
No longer available repry delete button etc in mail-headerfield
See attached screenshot

Expected Results:
All Buttons should be visible.
And Provide horizontal scroll bar so that another header items will be visible.


Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=997d19872dcfda69cf137ebc563d9bd2cc8a6ab5&tochange=86e1a9121b5d5bf67043e611b356462214a67dba
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b42bb6bb0be8723d0dd2b3c857c554cefa763062&tochange=095ec59a8800360154df6668394803e5a84d031c

Suspect: 	08bf719c34e9	Magnus Melin — Bug 1489748 - Migrate mail-headerfield and mail-urlfield to a single custom element. r=arshad

Comment 1

[Magnus Melin [:mkmelin]]

I don't see this on linux trunk at least.

Do you see this for all mails?

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1510266.png

Taken with trunk compiled a few hours ago. Looks fine to me, sorry about the French (testing lang packs). Also looking good in TB 64 beta 3.

Comment 3

[Alice0775 White]

(In reply to Jorg K (GMT+1) from comment #2)
> Created attachment 9028058 [details]
> 1510266.png
> 
> Taken with trunk compiled a few hours ago. Looks fine to me, sorry about the
> French (testing lang packs). Also looking good in TB 64 beta 3.


I can still reproduce the latest comm-cemtral Windows 2012 x64 opt.
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=fab70cf9e35485946adfc8a507210a6f837c64e0

Comment 4

[Alice0775 White]

Attachment: inbound 27-Nov-2018 104818.zip

could you test withe this email?

Comment 5

[Jorg K (CEST = GMT+2)]

Hmm, on TB 64 beta 3 I see the From line followed by a lot of empty space followed by the rest of the headers. There is a scrollbar, so I can scroll to the end. Magnus, what do you see?

Comment 6

[Richard Marti (:Paenglab)]

In fullscreen on my 3440px monitor everything is ok ;-). On a normal window width I see it too. The problem is that the headerValue elements for DKIM etc. are way too wide and don't break to new lines at the end of the window.

I saw also that the rules mail-headerfield > .headerValue:focus no more apply because of the changed structure.

Comment 7

[Magnus Melin [:mkmelin]]

Attachment: bug1510266_headerbuttons_out_of_view.patch

Comment 8

[Richard Marti (:Paenglab)]

Comment on attachment 9028236 [details] [diff] [review]
bug1510266_headerbuttons_out_of_view.patch

The focus is fixed now. But this patch creates big spaces between the headers when they overflow. I'll attach a screenshot.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: big_spaces.png

The spaces between the header fields when they overflow.

Comment 10

[Magnus Melin [:mkmelin]]

I've seen that in the stand-alone window, but I don't think it's due to this patch.

Comment 11

[Richard Marti (:Paenglab)]

Without patch the fields do wrap very wide and fill the gaps. With the patch they overflow but the narrower the window is the more space is between the fields. It looks like they wrap but no text is shown because of the overflow.

Comment 12

[Magnus Melin [:mkmelin]]

Attachment: bug1510266_headerbuttons_out_of_view.patch

Something odd going on here. If I add arbitrary max-height to some elements here the stray spacings clean up themselves.

Anyway, found a better fix that doesn't leave spaces either.

Comment 13

[Richard Marti (:Paenglab)]

Comment on attachment 9028585 [details] [diff] [review]
bug1510266_headerbuttons_out_of_view.patch

Thanks.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd4e2acab2ab
ensure header buttons are not pushed out of view when we have a long header. r=Paenglab

Comment 15

[Richard Leger]

Till patch land in 65.0 version, the obvious workaround to fix issue, for earlier affected version, is to set view setting to Normal (default value):

View > Headers > Normal