1510267 - Inline SVG text is cut off at bottom

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Andrew Overholt [:overholt]]

Attachment: clippedText.PNG

(I initially filed this as https://github.com/webcompat/web-bugs/issues/21764)

"of Canada" text is cut off at the bottom with WebRender but not without. It seems to be dependent upon how large the window is (it happens when I've got my browser maximized but not when it's split half the screen vertically.

(I tried the inline SVG on its own but it doesn't reproduce (like, it looks the same in Chrome and Firefox): https://codepen.io/anon/pen/yQjJpP)

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Testcase

Reduced test case. I saw the problem when I changed zoom level with latest nightly on linux.

Comment 2

[Sotaro Ikeda [:sotaro]]

On linux, I saw a bit of similar problem with BasicCompositor.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I see the bottom clipped on the reduced test case in Fennec (WR off) when zoomed all the way out. So most likely this is not actually WR-specific but some sort of snapping issue.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

This isn't bad enough to block shipping.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

This wasn't fixed by andrew's snapping fix.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

It appears to be caused by the latest snapping issues I've been investigating in bug 1453935 and bug 1523410.

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

(In reply to Andrew Osmond [:aosmond] from comment #6)

It appears to be caused by the latest snapping issues I've been investigating in bug 1453935 and bug 1523410.

I think I improved it, but after further testing, there is still one zoom level (60% with 200% scaling on Linux, or 120% with 100% scaling) where I still see the clipping.

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

Turns out, it was my patch that changed ToRoundedLayoutRect to work like ToLayoutRect that solved the text clipping. We need to figure out what is going wrong for the failing test cases, but this is likely the path forward for the correct solution.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

This is not WebRender specific. This renders the same on basic on Linux, and with advanced layers / d2d on Windows. If my snapping changes had an impact (with an updated patch, it doesn't appear to any longer), then I suspect it was more of a fluke than a proper resolution.

Comment 10

[Andrew Osmond [:aosmond] (he/him)]

I should also note that this can be reproduce on really old builds, e.g. 2015 so it has been around for a long time.