1510519 - Port Bug 1482395 - Move the WNP rules in-tree

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Rob Lemley [:rjl]]

This is a port of bug 1482395 to Comm. Build breakage on 2018-11-25.

[task 2018-11-27T21:56:24.225Z] Error loading tasks for kind release-balrog-submit-toplevel:
[task 2018-11-27T21:56:24.225Z] Traceback (most recent call last):
[task 2018-11-27T21:56:24.225Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 183, in taskgraph_decision
[task 2018-11-27T21:56:24.225Z]     return taskgraph.decision.taskgraph_decision(options)
[task 2018-11-27T21:56:24.225Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 169, in taskgraph_decision
[task 2018-11-27T21:56:24.225Z]     full_task_json = tgg.full_task_graph.to_json()
[task 2018-11-27T21:56:24.225Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 150, in full_task_graph
[task 2018-11-27T21:56:24.225Z]     return self._run_until('full_task_graph')
[task 2018-11-27T21:56:24.225Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 335, in _run_until
[task 2018-11-27T21:56:24.225Z]     k, v = self._run.next()
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 256, in _run
[task 2018-11-27T21:56:24.226Z]     new_tasks = kind.load_tasks(parameters, list(all_tasks.values()))
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 76, in load_tasks
[task 2018-11-27T21:56:24.226Z]     for task_dict in transforms(trans_config, inputs)]
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1903, in check_run_task_caches
[task 2018-11-27T21:56:24.226Z]     for task in tasks:
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1849, in check_task_dependencies
[task 2018-11-27T21:56:24.226Z]     for task in tasks:
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1837, in check_task_identifiers
[task 2018-11-27T21:56:24.226Z]     for task in tasks:
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1820, in chain_of_trust
[task 2018-11-27T21:56:24.226Z]     for task in tasks:
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1766, in build_task
[task 2018-11-27T21:56:24.226Z]     payload_builders[task['worker']['implementation']](config, task, task_def)
[task 2018-11-27T21:56:24.226Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1066, in build_balrog_payload
[task 2018-11-27T21:56:24.226Z]     'update_line': worker['update-line'],
[task 2018-11-27T21:56:24.226Z] KeyError: u'update-line'

Comment 1

[Rob Lemley [:rjl]]

Attachment: bugfix-1510519.patch

Changes tested with mach taskgraph locally.

Try run:
  https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=3cba862450f80a26601b89b5443aad8a062956be

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b682f20af95a
Port Bug 1482395: Move the WNP rules in-tree. rs=bustage-fix

Comment 3

[Jorg K (CEST = GMT+2)]

I guess this was reopened based on these IRC comments:

tom commented something about tbird not using it and i'm guessing that it being semi-broken is what is causing the purple ...

i think i can just disable the whats-new thing from last night.

Comment 4

[Rob Lemley [:rjl]]

Attachment: Bug 1510519 - Backed out changeset b682f20af95a, not used in TB. r?darktrojan

Removes unnecessarily ported code from Firefox's "What's New Page" feature.
Thunderbird does not use this.

Comment 5

[Rob Lemley [:rjl]]

Attachment: Bug 1510519 - Fix WNP build bustage. rs=bustage-fix, r?darktrojan

Adds a missing field (update-line) to the balrog-toplevel task. An empty
value bypasses the What's New Page blob generation on Balrog.

Depends on D15486

Comment 6

[Rob Lemley [:rjl]]

Successful run on try-comm-central.

Comment 7

[Rob Lemley [:rjl]]

(In reply to Rob Lemley [:rjl] from comment #6)
> Successful run on try-comm-central.

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=063713013cfb5936f8fd985b387759a2bbc22e8c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bd4ceeb571ce
Backed out changeset b682f20af95a, not used in TB. r=darktrojan
https://hg.mozilla.org/comm-central/rev/71d23319ac82
Fix WNP build bustage. rs=bustage-fix, r=darktrojan

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/releases/comm-esr60/rev/e12aa530cd172be7206483660a5352a003489187