Implement RTCRtpSender.setStreams()
Categories
(Core :: WebRTC, enhancement, P2)
Tracking
()
People
(Reporter: jib, Assigned: bwc)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files)
We need to implement sender.setStreams [1] and the reciprocal firing of the track event in response to stream association changes, as the spec dictates. [1] https://w3c.github.io/webrtc-pc/#dom-rtcrtpsender-setstreams
Reporter | ||
Updated•4 years ago
|
Comment 1•1 year ago
|
||
Any update on this in terms of timeline? Would appreciate support for this.
Assignee | ||
Comment 2•1 year ago
|
||
I think this should be easy, as we already have a [ChromeOnly] version of this function that probably does the right thing:
Assignee | ||
Comment 3•10 months ago
|
||
Once bug 1769802 lands, this should be easy. ni self to check back.
Updated•8 months ago
|
Assignee | ||
Comment 4•4 months ago
|
||
I think I'll fix bug 1808989 here while I'm at it.
Assignee | ||
Comment 5•4 months ago
|
||
Depends on D168415
Assignee | ||
Comment 6•4 months ago
|
||
Track ids have not meant anything in SDP for quite some time, and we aren't
even supposed to emit them. It is not valid to expect a browser to pay
any attention to them.
Depends on D168558
Assignee | ||
Comment 7•4 months ago
|
||
Depends on D168559
Assignee | ||
Comment 8•4 months ago
|
||
Assignee | ||
Comment 9•4 months ago
|
||
Try looks fine
Comment 10•4 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8dca8a4e260 Re-enable a bunch of wpt for setStreams. r=jib https://hg.mozilla.org/integration/autoland/rev/19435dddb76d Fix an invalid check in this wpt. r=jib https://hg.mozilla.org/integration/autoland/rev/67b457f83b21 Implement RTCRtpSender.setStreams. r=jib,webidl,smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38507 for changes under testing/web-platform/tests
Comment 12•4 months ago
|
||
Backed out for causing build bustages on PeerConnectionImpl.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]
mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland
Upstream PR merged by moz-wptsync-bot
Comment 14•4 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/34e7866083ab Re-enable a bunch of wpt for setStreams. r=jib https://hg.mozilla.org/integration/autoland/rev/60a8f3bbd888 Fix an invalid check in this wpt. r=jib https://hg.mozilla.org/integration/autoland/rev/b8688e4e6d58 Implement RTCRtpSender.setStreams. r=jib,webidl,smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38529 for changes under testing/web-platform/tests
Comment 16•4 months ago
|
||
Backed out for causing wpt failures in
Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836
Upstream PR merged by moz-wptsync-bot
Comment 18•3 months ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35f29af3a1b1 Re-enable a bunch of wpt for setStreams. r=jib https://hg.mozilla.org/integration/autoland/rev/b46f0ce13bce Fix an invalid check in this wpt. r=jib https://hg.mozilla.org/integration/autoland/rev/acbc27c298a8 Implement RTCRtpSender.setStreams. r=jib,webidl,smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38983 for changes under testing/web-platform/tests
Comment 20•3 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/35f29af3a1b1
https://hg.mozilla.org/mozilla-central/rev/b46f0ce13bce
https://hg.mozilla.org/mozilla-central/rev/acbc27c298a8
Upstream PR merged by moz-wptsync-bot
Updated•3 months ago
|
Comment 22•2 months ago
|
||
Can you please add a relnote request on this bug?
Assignee | ||
Comment 23•2 months ago
|
||
This has nothing to do with the browserstack problem. I think I just copied the wrong bug number here.
Still, I guess it is a new feature.
Assignee | ||
Comment 24•2 months ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]:
We're the last holdout on implementing this.
[Affects Firefox for Android]:
Yes.
[Suggested wording]:
Implemented support for RTCRtpSender.setStreams().
[Links (documentation, blog post, etc)]:
https://w3c.github.io/webrtc-pc/#dom-rtcrtpsender-setstreams
Updated•2 months ago
|
Updated•26 days ago
|
Description
•