1510802 - Implement RTCRtpSender.setStreams()

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

We need to implement sender.setStreams [1] and the reciprocal firing of the track event in response to stream association changes, as the spec dictates.

[1] https://w3c.github.io/webrtc-pc/#dom-rtcrtpsender-setstreams

Comment 1

[hassaanhafeez]

Any update on this in terms of timeline? Would appreciate support for this.

Comment 2

[Byron Campen [:bwc]]

I think this should be easy, as we already have a [ChromeOnly] version of this function that probably does the right thing:

https://searchfox.org/mozilla-central/rev/408eac3ccaea2d35b00706925d4d944803e19aba/dom/webidl/RTCRtpSender.webidl#26-27

Comment 3

[Byron Campen [:bwc]]

Once bug 1769802 lands, this should be easy. ni self to check back.

Comment 4

[Byron Campen [:bwc]]

I think I'll fix bug 1808989 here while I'm at it.

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1510802: Re-enable a bunch of wpt for setStreams. r?jib

Depends on D168415

Comment 6

[Byron Campen [:bwc]]

Attachment: Bug 1510802: Fix an invalid check in this wpt. r?jib

Track ids have not meant anything in SDP for quite some time, and we aren't
even supposed to emit them. It is not valid to expect a browser to pay
any attention to them.

Depends on D168558

Comment 7

[Byron Campen [:bwc]]

Attachment: Bug 1510802: Implement RTCRtpSender.setStreams. r?jib

Depends on D168559

Comment 8

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=362a9aa6bf755b613a37fd3a6afe421ec15f191c
https://treeherder.mozilla.org/jobs?repo=try&revision=1f237ae4a89a9294da66175451ff275ab9672243

Comment 9

[Byron Campen [:bwc]]

Try looks fine

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8dca8a4e260
Re-enable a bunch of wpt for setStreams. r=jib
https://hg.mozilla.org/integration/autoland/rev/19435dddb76d
Fix an invalid check in this wpt. r=jib
https://hg.mozilla.org/integration/autoland/rev/67b457f83b21
Implement RTCRtpSender.setStreams. r=jib,webidl,smaug

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38507 for changes under testing/web-platform/tests

Comment 12

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34e7866083ab
Re-enable a bunch of wpt for setStreams. r=jib
https://hg.mozilla.org/integration/autoland/rev/60a8f3bbd888
Fix an invalid check in this wpt. r=jib
https://hg.mozilla.org/integration/autoland/rev/b8688e4e6d58
Implement RTCRtpSender.setStreams. r=jib,webidl,smaug

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38529 for changes under testing/web-platform/tests

Comment 16

[Sandor Molnar]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35f29af3a1b1
Re-enable a bunch of wpt for setStreams. r=jib
https://hg.mozilla.org/integration/autoland/rev/b46f0ce13bce
Fix an invalid check in this wpt. r=jib
https://hg.mozilla.org/integration/autoland/rev/acbc27c298a8
Implement RTCRtpSender.setStreams. r=jib,webidl,smaug

Comment 19

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38983 for changes under testing/web-platform/tests

Comment 20

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/35f29af3a1b1
https://hg.mozilla.org/mozilla-central/rev/b46f0ce13bce
https://hg.mozilla.org/mozilla-central/rev/acbc27c298a8

Comment 21

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Can you please add a relnote request on this bug?

Comment 23

[Byron Campen [:bwc]]

This has nothing to do with the browserstack problem. I think I just copied the wrong bug number here.

Still, I guess it is a new feature.

Comment 24

[Byron Campen [:bwc]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
We're the last holdout on implementing this.
[Affects Firefox for Android]:
Yes.
[Suggested wording]:
Implemented support for RTCRtpSender.setStreams().
[Links (documentation, blog post, etc)]:
https://w3c.github.io/webrtc-pc/#dom-rtcrtpsender-setstreams

Comment 25

[Ryan VanderMeulen [:RyanVM]]

Sorry, pretend that was on bug 1531812 :)

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx113 Nightly relnotes.