1510899 - Enable catch-up compositing with WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Matt Woodrow (:mattwoodrow)]

Currently WebRender discards vsync notifications if there is an existing composite in progress, meaning that a slow composite forces the next one to also be delayed.

This is different to the non-WR behaviour, where slow composites block the vsync message from being processed, and we handle it late when we return to the message loop.

It's possible that this behaviour is preferable, but we want to minimize unrelated differences to make comparisons easier.

Comment 1

[Matt Woodrow (:mattwoodrow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b359cb76be1cb87fed67b44a36ad487466c52001

Comment 2

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1510899 - Try catch up composites with WR. r?jrmuizel,sotaro

MozReview-Commit-ID: LXIpsvZZ96U

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55abd0f51161
Try catch up composites with WR. r=jrmuizel,sotaro

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/55abd0f51161

Comment 5

[Florin Strugariu [:Bebe]]

This bug caused a performance regression on thalos see bug 1511797

Comment 6

[Bobby Holley (:bholley)]

This regressed tp5o_scroll on Windows [1]. Matt?

[1] https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,1663184,1,1&series=autoland,1684084,1,1&series=mozilla-central,1538379,1,1&zoom=1543495379899.2747,1543565056579.3716,2.163670371980703,2.9632958401454967&selected=autoland,1684084,409386,660044972,1

Comment 7

[Matt Woodrow (:mattwoodrow)]

(In reply to Bobby Holley (:bholley) from comment #6)
> This regressed tp5o_scroll on Windows [1]. Matt?
> 
> [1]
> https://treeherder.mozilla.org/perf.html#/graphs?series=mozilla-central,
> 1663184,1,1&series=autoland,1684084,1,1&series=mozilla-central,1538379,1,
> 1&zoom=1543495379899.2747,1543565056579.3716,2.163670371980703,2.
> 9632958401454967&selected=autoland,1684084,409386,660044972,1

Looks like we have bug 1511797 tracking this now, I'm investigating.