Add automatical telemetry test for socket process

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P2
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: kershaw, Assigned: junior)

Tracking

(Blocks 1 bug)

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 attachment)

(Reporter)

Description

5 months ago
This is a follow up of bug 1486033. Please also see https://phabricator.services.mozilla.com/D8206#208002.

After the plumbing is done, we need to add some automical tests.
(Reporter)

Updated

5 months ago
Blocks: socket-proc
Moving as this doesn't directly fall into our work.
When adding telemetry to anything in the network process these parts should have tests. Please approach me (or someone else from the Telemetry team) for help with that if needed.
Component: Telemetry → Networking
Product: Toolkit → Core
(Assignee)

Updated

5 months ago
Priority: -- → P3
Whiteboard: [necko-triaged]
We will need this soon , it is needed for webRTC.
Priority: P3 → P2
Michal - can you tackle this soon?
Assignee: nobody → michal.novotny
Flags: needinfo?(michal.novotny)
(Reporter)

Comment 4

4 months ago
(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #3)
> Michal - can you tackle this soon?

I think maybe Junior can help to tackle, since Michal is not working on socket process.
Flags: needinfo?(michal.novotny) → needinfo?(juhsu)
(Assignee)

Updated

4 months ago
Assignee: michal.novotny → juhsu
Flags: needinfo?(juhsu)
(Assignee)

Comment 5

4 months ago
After discussion with Jan-Erik, we can reuse the SOCKET_ONLY_UINT introduced by bug 1486033.

We need a test-only IPC message to socket process to trigger the Telemetry::Scalar set since no js engine in the socket process.
And hook the IPC to AddPendingEvent (will be renamed |CallOrWaitSocketProcess|) introduced by bug 1496257.
(Assignee)

Comment 6

4 months ago
We need a test-only IPC message to socket process to trigger the Telemetry::Scalar set since no js engine in the socket process.
And hook the IPC call to AddPendingEvent |CallOrWaitSocketProcess| introduced by bug 1496257.
Unfortunately that has build failures, due to being based on an old patch of bug 1513057. As soon as that other bug lands another quick try run would be good (doesn't even need to be across the full range of platforms)
(Assignee)

Comment 9

3 months ago

rebased to central
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4942a91c8660dd060063c3728d0076686ce1376

I try to enable the pref in all.js, but SocketProcessHost::OnChannelError() is called.

Comment 10

3 months ago
Pushed by juhsu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe00e2fad26f
add a telemetry xpcshell-test for socket process r=janerik

Comment 11

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.