1510979 - Add automatical telemetry test for socket process

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P2)

Description

[Kershaw Chang [:kershaw]]

This is a follow up of bug 1486033. Please also see https://phabricator.services.mozilla.com/D8206#208002.

After the plumbing is done, we need to add some automical tests.

Comment 1

[Jan-Erik Rediger [:janerik]]

Moving as this doesn't directly fall into our work.
When adding telemetry to anything in the network process these parts should have tests. Please approach me (or someone else from the Telemetry team) for help with that if needed.

Comment 2

[Dragana Damjanovic [:dragana]]

We will need this soon , it is needed for webRTC.

Comment 3

[Selena Deckelmann :selenamarie :selena]

Michal - can you tackle this soon?

Comment 4

[Kershaw Chang [:kershaw]]

(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #3)
> Michal - can you tackle this soon?

I think maybe Junior can help to tackle, since Michal is not working on socket process.

Comment 5

[Junior [inactive]]

After discussion with Jan-Erik, we can reuse the SOCKET_ONLY_UINT introduced by bug 1486033.

We need a test-only IPC message to socket process to trigger the Telemetry::Scalar set since no js engine in the socket process.
And hook the IPC to AddPendingEvent (will be renamed |CallOrWaitSocketProcess|) introduced by bug 1496257.

Comment 6

[Junior [inactive]]

Attachment: Bug 1510979 - add a telemetry xpcshell-test for socket process

We need a test-only IPC message to socket process to trigger the Telemetry::Scalar set since no js engine in the socket process.
And hook the IPC call to AddPendingEvent |CallOrWaitSocketProcess| introduced by bug 1496257.

Comment 7

[Junior [inactive]]

Treeherder
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e224569116ee31f80dd03bada82c4172b8cdba18

It depends on bug 1513057.

Comment 8

[Jan-Erik Rediger [:janerik]]

Unfortunately that has build failures, due to being based on an old patch of bug 1513057. As soon as that other bug lands another quick try run would be good (doesn't even need to be across the full range of platforms)

Comment 9

[Junior [inactive]]

rebased to central
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4942a91c8660dd060063c3728d0076686ce1376

I try to enable the pref in all.js, but SocketProcessHost::OnChannelError() is called.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe00e2fad26f
add a telemetry xpcshell-test for socket process r=janerik

Comment 11

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/fe00e2fad26f