Closed Bug 1510979 Opened 2 years ago Closed 2 years ago

Add automatical telemetry test for socket process

Categories

(Core :: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla66
Tracking Status
firefox66 --- fixed

People

(Reporter: kershaw, Assigned: junior)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

This is a follow up of bug 1486033. Please also see https://phabricator.services.mozilla.com/D8206#208002.

After the plumbing is done, we need to add some automical tests.
Blocks: socket-proc
Moving as this doesn't directly fall into our work.
When adding telemetry to anything in the network process these parts should have tests. Please approach me (or someone else from the Telemetry team) for help with that if needed.
Component: Telemetry → Networking
Product: Toolkit → Core
Priority: -- → P3
Whiteboard: [necko-triaged]
We will need this soon , it is needed for webRTC.
Priority: P3 → P2
Michal - can you tackle this soon?
Assignee: nobody → michal.novotny
Flags: needinfo?(michal.novotny)
(In reply to Selena Deckelmann :selenamarie :selena use ni? pronoun: she from comment #3)
> Michal - can you tackle this soon?

I think maybe Junior can help to tackle, since Michal is not working on socket process.
Flags: needinfo?(michal.novotny) → needinfo?(juhsu)
Assignee: michal.novotny → juhsu
Flags: needinfo?(juhsu)
After discussion with Jan-Erik, we can reuse the SOCKET_ONLY_UINT introduced by bug 1486033.

We need a test-only IPC message to socket process to trigger the Telemetry::Scalar set since no js engine in the socket process.
And hook the IPC to AddPendingEvent (will be renamed |CallOrWaitSocketProcess|) introduced by bug 1496257.
We need a test-only IPC message to socket process to trigger the Telemetry::Scalar set since no js engine in the socket process.
And hook the IPC call to AddPendingEvent |CallOrWaitSocketProcess| introduced by bug 1496257.
Unfortunately that has build failures, due to being based on an old patch of bug 1513057. As soon as that other bug lands another quick try run would be good (doesn't even need to be across the full range of platforms)

rebased to central
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4942a91c8660dd060063c3728d0076686ce1376

I try to enable the pref in all.js, but SocketProcessHost::OnChannelError() is called.

Pushed by juhsu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fe00e2fad26f
add a telemetry xpcshell-test for socket process r=janerik
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.