Closed
Bug 1510997
Opened 5 years ago
Closed 5 years ago
WebExtensions pkcs11 missing
Categories
(Thunderbird :: Add-Ons: Extensions API, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 66.0
People
(Reporter: mvogt1, Assigned: darktrojan)
Details
Attachments
(1 file)
2.78 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 Steps to reproduce: I have a working AddOn for firefox, which adds a pkcs11 driver as "security module". With this AddOn I can use my smartcard, the SecurityModule gets installed. I tried the same with thunderbird. I used the addon in thunderbird 60.3.1 (64bit, linux), binary download from morzilla.org. The error (see below) indicates, that thunderbird is missing the "WebExtensions/API/pkcs11" https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pkcs11 Is this true? Actual results: When using the addon in thunderbird, I get the error: Reading manifest: Error processing permissions.0: Value "pkcs11" must either: must either [must either [be one of ["clipboardRead", "clipboardWrite", "geolocation", "idle", "notifications"], be one of ["activeTab", "tabs", "tabHide"], be one of ["browserSettings"], be one of ["cookies"], be one of ["downloads", "downloads.open"], be one of ["topSites"], be one of ["webNavigation"], or be one of ["webRequest", "webRequestBlocking"]], be one of ["alarms", "mozillaAddons", "storage", "unlimitedStorage"], be one of ["contextualIdentities"], be one of ["dns"], be one of ["management"], be one of ["privacy"], be one of ["proxy"], be one of ["nativeMessaging"], be one of ["theme"], or match the pattern /^experiments(\.\w+)+$/], or must either [be one of ["<all_urls>"], must either [match the pattern /^(https?|wss?|file|ftp|\*):\/\/(\*|\*\.[^*/]+|[^*/]+)\/.*$/, or match the pattern /^file:\/\/\/.*$/], or match the pattern /^resource:\/\/(\*|\*\.[^*/]+|[^*/]+)\/.*$|^about:/] Expected results:
Assignee | ||
Comment 2•5 years ago
|
||
Thunderbird doesn't have that API yet. Should be an easy fix, I'll add it to the bottom of my hundred-things-to-do-this-weekend list.
Flags: needinfo?(geoff)
Assignee | ||
Updated•5 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Reporter | ||
Comment 3•5 years ago
|
||
>Thunderbird doesn't have that API yet. Should be an easy fix,
>I'll add it to the bottom of my hundred-things-to-do-this-weekend list.
Many thanks.
I will test it, as soon as it is available.
Assignee | ||
Comment 4•5 years ago
|
||
Rather than copy the files and have to keep them updated, I've just linked to the Firefox version in jar.mn.
Comment 5•5 years ago
|
||
Comment on attachment 9032068 [details] [diff] [review] 1510997-pkcs11-1.diff Review of attachment 9032068 [details] [diff] [review]: ----------------------------------------------------------------- If this is the same file and it would work for other toolkit apps, can you just move this from browser to toolkit like I did for bug 1507709 ? Code looks ok so r+ on that, but maybe you can consider moving it to toolkit.
Attachment #9032068 -
Flags: review?(philipp) → review+
Assignee | ||
Comment 6•5 years ago
|
||
I think the reason it's not in toolkit is that they don't want it on Android. But that's only a guess.
Comment 7•5 years ago
|
||
Based on the review comment in bug 1507709 it seems they are fine having it in toolkit but disabling on Android.
Assignee | ||
Comment 8•5 years ago
|
||
Looking at bug 1357391 comment 64, this should remain in browser. I don't actually see how it could be in toolkit and not on Android, as the module would have to be in ext-toolkit.json, which can't be conditional on platform.
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/08d2439c1365 Link to WebExtensions pkcs11 module in browser/components/extensions; r=Fallen
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 66.0
Reporter | ||
Comment 10•5 years ago
|
||
Many thanks, I have tested:
- thunderbird-66.0a1.en-US.win32
and the AddOn works now.
You need to log in
before you can comment on or make changes to this bug.
Description
•