1511174 - USPS.com keyboard covers address input field

Status: RESOLVED WORKSFORME

(GeckoView :: IME, defect, P1)

Description

[Chris Peterson [:cpeterson]]

STR:
1. Open USPS.com
2. Tap on 'change my address' and then 'get started'
3. Tap on any input fields

Expected behavior

As the keyboard opens, the input field should move up so the user can see what they are typing.

Actual behavior

Input field is covered by the keyboard.

Vesta filed a Focus issue:
https://github.com/mozilla-mobile/focus-android/issues/3985

See also old Fennec bug 1325030 and bug 1309551.

Comment 1

[Chris Peterson [:cpeterson]]

Here is a video reproducing the keyboard issue:

https://docs.google.com/presentation/d/1-9EmORROWirZ2KeRjYDPZqT-A3Ph8GzRpiJSVZkzRfo/edit#slide=id.g48451af66a_2_15

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

I think things are going wrong because the input field is in a scrollable element. We get here[0] and then end up with an empty rect. Maire, could we get some help with this?

[0] https://searchfox.org/mozilla-central/rev/e22c0d152060f4f8d4ca8904094f15f65a1b6f93/layout/base/nsLayoutUtils.cpp#9825

Comment 3

[Maire Reavy [:mreavy]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #2)
> I think things are going wrong because the input field is in a scrollable
> element. We get here[0] and then end up with an empty rect. Maire, could we
> get some help with this?
> 
> [0]
> https://searchfox.org/mozilla-central/rev/
> e22c0d152060f4f8d4ca8904094f15f65a1b6f93/layout/base/nsLayoutUtils.cpp#9825

Cameron -- Thoughts about what's going on here?  usps is a pretty major site.

Comment 4

[Chris Peterson [:cpeterson]]

P1 since this will frustrate users trying to enter data in a form.

Comment 5

[Makoto Kato [:m_kato]]

We don't call nsISelectionController::ScrollSelectionIntoView after opening virtual keyboard.  Editor calls it on focus event, but it is before opening virtual keyboard.

Comment 6

[Chris Peterson [:cpeterson]]

P1 for Fenix

Comment 7

[Makoto Kato [:m_kato]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #2)
> I think things are going wrong because the input field is in a scrollable
> element. We get here[0] and then end up with an empty rect. Maire, could we
> get some help with this?
> 
> [0]
> https://searchfox.org/mozilla-central/rev/
> e22c0d152060f4f8d4ca8904094f15f65a1b6f93/layout/base/nsLayoutUtils.cpp#9825

It seems to be regression by bug 1204084.

Comment 8

[Makoto Kato [:m_kato]]

I cannot reproduce this today.... (Focus 8.0.6) hmm.

Comment 9

[vzare]

I cannot reproduce this anymore either. We can close this.

Comment 10

[Makoto Kato [:m_kato]]

OK, I close as WFM. But I continue same issue by bug 1149300.

Comment 11

[Guy Abossolo Foh]

Works fine except when the field has a css property position set to fixed (uncommented).
This occurs only with GeckoView. With Android WebView the Field is displayed at the top of the keyboard.

#mycurrentmessage {
/position : fixed;/
bottom : 0;
left : 0;
right : 0;
background-color: #ffffff;
border: 1px solid #e6e6e6;
margin-top: 20px;
/arrondir les coins en haut à gauche et en bas à droite/
border-radius: 10px 10px;
/min-height: 20%;/
}

Comment 12

[Guy Abossolo Foh]

Works fine except when the field has a css property position set to fixed (uncommented).
This occurs only with GeckoView. With Android WebView the Field is displayed at the top of the keyboard.

#mycurrentmessage {
    /*position : fixed;*/
    bottom : 0;
    left : 0;
    right : 0;
    background-color: #ffffff;
    border: 1px solid #e6e6e6;
    margin-top: 20px;
    border-radius: 10px 10px;
}

Comment 13

[Makoto Kato [:m_kato]]

(In reply to Guy Abossolo Foh from comment #12)

Works fine except when the field has a css property position set to fixed (uncommented).
This occurs only with GeckoView. With Android WebView the Field is displayed at the top of the keyboard.

Could you file a new bug since this is another issue?

Comment 14

[Guy Abossolo Foh]

(In reply to Makoto Kato [:m_kato] from comment #13)

(In reply to Guy Abossolo Foh from comment #12)

Works fine except when the field has a css property position set to fixed (uncommented).
This occurs only with GeckoView. With Android WebView the Field is displayed at the top of the keyboard.

Could you file a new bug since this is another issue?

Yes, I going to file a new bug. Thanks.

Comment 15

[Guy Abossolo Foh]

Done : Bug 1625644.

Comment 16

[Chris Peterson [:cpeterson]]

Moving some keyboard bugs to the new GeckoView::IME component.