Replace nsINavBookmarksService::onItemRemoved with "bookmark-removed"
Categories
(Toolkit :: Places, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox74 | --- | fixed |
People
(Reporter: Siddhant085, Assigned: Siddhant085, Mentored)
References
Details
Attachments
(1 file)
Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Comment 1•7 years ago
|
||
Siddhant: a minor change, please could we call this "bookmark-removed" for now.
Assignee | ||
Comment 2•6 years ago
|
||
Phasing out the old notification system for OnItemRemoved events.
Comment 4•6 years ago
|
||
Backed out changeset 1bdfd7c37b02 (Bug 1511700) for causing newtab node test failure CLOSED TREE
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284730858&repo=autoland&lineNumber=335
Comment 6•6 years ago
|
||
Siddhant, you should be able to run the failing tests by:
$ cd browser/components/newtab # in the source directory
$ npm install
$ npm run testmc:unit
Let us know if you need help.
Comment 7•6 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #6)
$ npm install
npm ci
is probably a better command here, but does basically the same thing.
Assignee | ||
Comment 8•6 years ago
|
||
I have fixed the tests and updated my changes.
https://phabricator.services.mozilla.com/D17753
Comment 9•6 years ago
|
||
Thanks, those changes look good. I've just re-triggered the landing.
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
bugherder |
Comment 12•6 years ago
|
||
It has landed! Thank you Siddhant for all your work on this, it is great to finally get this in.
Description
•