Open Bug 1512153 Opened 6 years ago Updated 2 years ago

Use ES Classes for protocol.js Actors

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Similarly to bug 1510949, we can convert all protocol.js Actors to use ES Classes. It should be easier as there is no custom/preEvent special cases. And it should help implementing actor inheritance for the target actors.
Blocks: 1512154
In bug 1512154, I had to workaround the fact that Actors weren't using ES Classes yet. Because of that I had to duplicate Pool's contructor into Actor.initialize method: // Repeat Pool.constructor here as we can't call it from initialize // This is to be removed once actors switch to es classes and are able to call // Actor's contructor. if (conn) { this.conn = conn; } We should remember here to remove that and instead call super(conn) once initialize becomes Actor.constructor.
Severity: normal → S3
Assignee: nobody → poirot.alex
Depends on: 1813475
Depends on: 1813476
Depends on: 1813477
Depends on: 1813478
Depends on: 1813479
Blocks: 1813648
Depends on: 1813995
Depends on: 1814011
Blocks: 1814013
You need to log in before you can comment on or make changes to this bug.