1512813 - (visual-viewport-api) Enable Visual Viewport API by default on Android

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Jan Henning [:JanH]]

I.e. flip "dom.visualviewport.enabled" to true by default.

As far as I can see, this won't be required for internal session store/history usage, though, because
a) I intend to use some additional internal events that don't require listening on the VisualViewport object
b) there already are some internal helper methods for getting the visual viewport offset without going through the VisualViewport object

Comment 1

[Botond Ballo [:botond]]

Kats, what do you think about making dom.visualviewport.enabled conditional on apz.allow_zooming (and, until bug 1459260 is resolved, dom.meta-viewport.enabled)?

The motivation for this is that correct updating of the visual viewport properties and dispatching of events and such currently relies on MobileViewportManager. We'd have to add new codepaths if we wanted e.g. visual viewport resize events to be fired without apz.allow_zooming=true.

Seeing as the motivating uses of the Visual Viewport API involve zooming, and even if we added such non-zooming codepaths now, they'd go way when we implemented desktop zooming, it seems to me that doing so would be rather pointless.

Thoughts?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

That seems reasonable to me.

Comment 3

[Botond Ballo [:botond]]

Intent to ship email: https://groups.google.com/forum/#!topic/mozilla.dev.platform/Mkw_Toh9Siw

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1512813 - Enable the Visual Viewport API on Android. r=kats

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90bd618a9449
Enable the Visual Viewport API on Android. r=kats

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/90bd618a9449

Comment 7

[Botond Ballo [:botond]]

Updating bug title to reflect that the enablement by default happened on Android only for now.

Enablement by default on desktop is tracked in bug 1551302 and depends on desktop zooming.

Comment 8

[Eric Shepherd [:sheppy]]

Documentation updates:

• Submitted [BCD PR 4347)(https://github.com/mdn/browser-compat-data/pull/4347) noting that VisualViewport is now enabled by default on Android Firefox.
• Listed on Firefox 68 for developers