Closed Bug 1512813 (visual-viewport-api) Opened 11 months ago Closed 6 months ago

Enable Visual Viewport API by default on Android

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: JanH, Assigned: botond)

References

(Blocks 3 open bugs)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

I.e. flip "dom.visualviewport.enabled" to true by default.

As far as I can see, this won't be required for internal session store/history usage, though, because
a) I intend to use some additional internal events that don't require listening on the VisualViewport object
b) there already are some internal helper methods for getting the visual viewport offset without going through the VisualViewport object
Blocks: 1514429
Alias: visual-viewport-api
Depends on: 1543485
Blocks: 1543553

Kats, what do you think about making dom.visualviewport.enabled conditional on apz.allow_zooming (and, until bug 1459260 is resolved, dom.meta-viewport.enabled)?

The motivation for this is that correct updating of the visual viewport properties and dispatching of events and such currently relies on MobileViewportManager. We'd have to add new codepaths if we wanted e.g. visual viewport resize events to be fired without apz.allow_zooming=true.

Seeing as the motivating uses of the Visual Viewport API involve zooming, and even if we added such non-zooming codepaths now, they'd go way when we implemented desktop zooming, it seems to me that doing so would be rather pointless.

Thoughts?

Flags: needinfo?(kats)

That seems reasonable to me.

Flags: needinfo?(kats)
Depends on: 1549622
Depends on: 1549625
Assignee: nobody → botond
No longer depends on: 1549625
No longer depends on: 1549622
No longer depends on: 1543485
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/90bd618a9449
Enable the Visual Viewport API on Android. r=kats
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Updating bug title to reflect that the enablement by default happened on Android only for now.

Enablement by default on desktop is tracked in bug 1551302 and depends on desktop zooming.

See Also: → 1551302
Summary: Enable Visual Viewport API by default → Enable Visual Viewport API by default on Android

Documentation updates:

You need to log in before you can comment on or make changes to this bug.