Open Bug 1551302 (visual-viewport-api-desktop) Opened 2 years ago Updated 2 months ago

Enable the Visual Viewport API on desktop

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

Tracking Status
firefox68 --- affected

People

(Reporter: botond, Unassigned)

References

(Depends on 1 open bug, Blocks 2 open bugs)

Details

(Keywords: dev-doc-needed)

In bug 1512813, we have enabled the Visual Viewport API by default on Android.

This bug tracks also enabling it by default on desktop, which depends on (and should be released concurrently with) desktop zooming.

Type: defect → enhancement
See Also: → visual-viewport-api

This should probably block desktop zooming riding the trains to release.

Alias: visual-viewport-api-desktop

(Also removing the desktop-zooming-xp dependency since I believe desktop zooming now works well enough that work on this is unblocked. If we discover specific open dependencies we can add them individually.)

No longer depends on: desktop-zoom-xp

Looks like only unrelated intermittents, so we could flip the pref now if we wanted.

I wonder if we should also be dropping the meta-viewport pref from https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/css-device-adapt/__dir__.ini and https://searchfox.org/mozilla-central/source/testing/web-platform/meta/visual-viewport/__dir__.ini. But that could be deferred to a follow-up.

If we do flip the pref (I'm in favour of doing it), we should send an intent email to dev-platform first.

Marking all the tests as passing on desktop that were only marked as passing on android in the visual-viewport directory looks like we have one failure

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4b0fe30c51d874c5982df3260eedc1f19c325ea

TEST-UNEXPECTED-FAIL | /visual-viewport/viewport-resize-event-on-load-overflowing-page.html | Resize event fired exactly once against window.visualViewport if scrollbars affect layout. - assert_equals: expected 1 but got 3

The test also fails when I run it locally with overlay scrollbars, this time we get 1 resize event and 0 are expected.

@martin: Do you have an overview on how much the visual viewport api is used and what the priority of this would be for release.

Flags: needinfo?(mbalfanz)

Thanks for bringing this up!

My initial research shows quite a bit of use in production (e.g. fullstory.com and zendesk) and open source (quasar framework, popper.js and more). I want to better understand how it's used to get a feeling for potential webcompat issues if we decide not to ship it. I'll get back to you as soon as I know more, but my gut feeling is that we should be OK without it.

Flags: needinfo?(mbalfanz)
Depends on: 1546387
You need to log in before you can comment on or make changes to this bug.