about:debugging category style is broken

VERIFIED FIXED in Firefox 65

Status

()

defect
P3
normal
VERIFIED FIXED
9 months ago
8 months ago

People

(Reporter: ntim, Assigned: Matthias)

Tracking

({regression})

unspecified
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox64 unaffected, firefox65 verified, firefox66 verified)

Details

Attachments

(2 attachments)

No description provided.
Assignee: nobody → matthias
Status: NEW → ASSIGNED
Attachment #9030362 - Attachment description: Bug 1512887 - Overwrote button background styling. r=ntim → Bug 1512887 - Overwrote button background styling. r=dao
Priority: -- → P3
Attachment #9030362 - Attachment description: Bug 1512887 - Overwrote button background styling. r=dao → Bug 1512887 - Overwrote button background styling. r=ntim
Attachment #9030362 - Attachment description: Bug 1512887 - Overwrote button background styling. r=ntim → Bug 1512887 - Overwrote button background styling. r=dao
Attachment #9030362 - Attachment description: Bug 1512887 - Overwrote button background styling. r=dao → Bug 1512887 - Fix category styling by overriding button background. r=dao
Thanks for working on this, I was about to work onit. 
Could we request an uplift to beta when this lands ?
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8faacdfed47b
Fix category styling by overriding button background. r=dao
https://hg.mozilla.org/mozilla-central/rev/8faacdfed47b
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Please nominate this patch for Beta approval when you get a chance.
Flags: needinfo?(matthias)
Comment on attachment 9030362 [details]
Bug 1512887 - Fix category styling by overriding button background. r=dao

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1511394

User impact if declined: See comment 1, also required for bug 1514058

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: See comment 1

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): css only

String changes made/needed:
Attachment #9030362 - Flags: approval-mozilla-beta?
Flags: needinfo?(matthias)
Comment on attachment 9030362 [details]
Bug 1512887 - Fix category styling by overriding button background. r=dao

[Triage Comment]
Simple CSS fix, approved for 65.0b5.
Attachment #9030362 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
I managed to reproduce the issue using an older version of Nightly (2018-12-09) on Windows 10 x64.
I verified the fix using latest Nightly 66.0a1 and beta 65.0b5 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.