Closed
Bug 1512887
Opened 6 years ago
Closed 6 years ago
about:debugging category style is broken
Categories
(Toolkit :: Themes, defect, P3)
Toolkit
Themes
Tracking
()
VERIFIED
FIXED
mozilla66
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox64 | --- | unaffected |
| firefox65 | --- | verified |
| firefox66 | --- | verified |
People
(Reporter: ntim, Assigned: Kammueller)
References
Details
(Keywords: regression)
Attachments
(2 files)
|
24.91 KB,
image/png
|
Details | |
|
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Screen Shot 2018-12-09 at 22.35.44.png
No description provided.
|
Reporter | |
Comment 1•6 years ago
|
||
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → matthias
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9030362 -
Attachment description: Bug 1512887 - Overwrote button background styling. r=ntim → Bug 1512887 - Overwrote button background styling. r=dao
|
||
Updated•6 years ago
|
Priority: -- → P3
|
|
||
Updated•6 years ago
|
Attachment #9030362 -
Attachment description: Bug 1512887 - Overwrote button background styling. r=dao → Bug 1512887 - Overwrote button background styling. r=ntim
|
|
||
Updated•6 years ago
|
Attachment #9030362 -
Attachment description: Bug 1512887 - Overwrote button background styling. r=ntim → Bug 1512887 - Overwrote button background styling. r=dao
|
|
||
Updated•6 years ago
|
Attachment #9030362 -
Attachment description: Bug 1512887 - Overwrote button background styling. r=dao → Bug 1512887 - Fix category styling by overriding button background. r=dao
|
||
Comment 3•6 years ago
|
||
Thanks for working on this, I was about to work onit.
Could we request an uplift to beta when this lands ?
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8faacdfed47b
Fix category styling by overriding button background. r=dao
|
|
||
Updated•6 years ago
|
status-firefox64:
--- → unaffected
status-firefox65:
--- → affected
status-firefox66:
--- → affected
Keywords: regression
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
|
||
Comment 6•6 years ago
|
||
Please nominate this patch for Beta approval when you get a chance.
status-firefox-esr60:
--- → unaffected
Flags: needinfo?(matthias)
|
|
Reporter | |
Comment 7•6 years ago
|
||
Comment on attachment 9030362 [details]
Bug 1512887 - Fix category styling by overriding button background. r=dao
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Bug 1511394
User impact if declined: See comment 1, also required for bug 1514058
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: No
Needs manual test from QE?: Yes
If yes, steps to reproduce: See comment 1
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): css only
String changes made/needed:
Attachment #9030362 -
Flags: approval-mozilla-beta?
|
|
Reporter | |
Updated•6 years ago
|
Flags: needinfo?(matthias)
|
|
||
Comment 8•6 years ago
|
||
Comment on attachment 9030362 [details]
Bug 1512887 - Fix category styling by overriding button background. r=dao
[Triage Comment]
Simple CSS fix, approved for 65.0b5.
Attachment #9030362 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 9•6 years ago
|
||
| bugherder uplift | ||
|
||
Updated•6 years ago
|
Flags: qe-verify+
|
||
Comment 10•6 years ago
|
||
I managed to reproduce the issue using an older version of Nightly (2018-12-09) on Windows 10 x64.
I verified the fix using latest Nightly 66.0a1 and beta 65.0b5 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•