Closed Bug 1514058 Opened 2 years ago Closed 2 years ago
about:debugging sidebar link no longer look selected
47 bytes, text/x-phabricator-request
|Details | Review|
Regression from Bug 1512889 From common.css, buttons now force: color: inherit !important Which overrides color: var(--in-content-category-text-selected); set on `#categories > .category.selected`
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
This is actually a regression of bug 1473922, since bug 1473922 actually introduced the !important.
Dão, having seen both patches from bug 1512887 and here, I'm not sure what's the best approach, bug 1512887 seems to be providing a toolkit side fix in common.css, while this bug provides a devtools specific fix in aboutdebugging.css. I don't have any preference over both approaches since they both have their pros and cons, but I want to make sure we end up having a consistent fix for both bugs. One argument for having the fix in toolkit, is that common.css is supposed to cater for all use-cases. One argument for having the fix in aboutdebugging.css is that about:debugging is the only page that uses buttons as categories, and that we already seem to have some CSS for that: https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/aboutdebugging.css#23-34
Doing it all in aboutdebugging.css sounds good to me. Bug 1512887 landed now, and this bug can move the rule added there.
We can do that we just need to make sure to uplift Bug 1512887 first.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/43dffe328a3b Restore color of selected about:debugging category;r=ntim
Please nominate this for Beta approval when you get a chance (feel free to take the NI in bug 1512887 too if needed).
Comment on attachment 9031278 [details] Bug 1514058 - Restore color of selected about:debugging category;r=ntim [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 1473922 User impact if declined: Selected category text color is no longer blue in about:debugging Is this code covered by automated tests?: No Has the fix been verified in Nightly?: No Needs manual test from QE?: Yes If yes, steps to reproduce: Check if selected category text color is blue in about:debugging List of other uplifts needed: Bug 1512887 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): css only String changes made/needed: none
Attachment #9031278 - Flags: approval-mozilla-beta?
Comment on attachment 9031278 [details] Bug 1514058 - Restore color of selected about:debugging category;r=ntim [Triage Comment] Simple CSS fix, approved for 65.0b5.
Attachment #9031278 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
I’ve reproduced this issue on an affected Nightly build (2018-12-13). I can confirm the selected about:debugging category turns blue on Beta 65.0b5 (20181217180946) and Nightly 66.0a1 (2018-12-19) builds, with Windows 10 x64, Ubuntu 18.04 x64 and macOS 10.13.
You need to log in before you can comment on or make changes to this bug.