1513483 - Perf alerts missing platform names

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

Perf alerts no longer mention their originating platform.

This applies to the generated reports as well.

At the moment, we can find out these platforms by either going into the Graphs view or looking at the alert summary title.

Comment 1

[Ionuț Goldan [:igoldan]]

Attachment: missing-originating-platforms.png

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Ionuț Goldan [:igoldan], Performance Sheriffing from comment #0)
> This applies to the generated reports as well.

If you look on this newly filed perf bug [1], you'll see this generated report. A developer wouldn't know which platform got affected.

> Regressions:
>
>  6%  tp5o_webext responsiveness opt e10s stylo     1.68 -> 1.78
>  3%  tp5o_webext responsiveness pgo e10s stylo     1.44 -> 1.48
>

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1513471#c0

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/4363

Comment 4

[Ed Morley [:emorley]]

To clarify, the dependency tree change is since this regression bug was caused by bug 1506553, and we typically mark the regression bug as blocking the one that caused it. The regressing bug (bug 1506553) was itself a transient dependency of the React meta bug, so I swapped the deps instead of adding it addition to it, otherwise the dep tree has duplicate branches.

This is the pattern we've used for the other React work:
https://bugzilla.mozilla.org/showdependencytree.cgi?id=1409103&hide_resolved=0

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Ed Morley [:emorley] from comment #4)
> To clarify, the dependency tree change is since this regression bug was
> caused by bug 1506553, and we typically mark the regression bug as blocking
> the one that caused it. The regressing bug (bug 1506553) was itself a
> transient dependency of the React meta bug, so I swapped the deps instead of
> adding it addition to it, otherwise the dep tree has duplicate branches.
> 
> This is the pattern we've used for the other React work:
> https://bugzilla.mozilla.org/showdependencytree.
> cgi?id=1409103&hide_resolved=0

Thanks for clarifying this! Will properly assign regression bugs next time.

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ff2621a63325fffc96547b04879648958cb90767
Bug 1513483 - Re add platform name to alerts (#4363)