151364 - Sending unsent messages doesn't try to send other mails if one fails

Status: RESOLVED WORKSFORME

(MailNews Core :: Networking: SMTP, defect)

Description

[Christian Eyrich]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.1a) Gecko/20020610
BuildID:    2002061014

If more than one mail resides in Unsent Messages and you're trying to send them
Mozilla give up sending them if one fails.
I think it should try to send the other ones - especially if they should be send
via other smtp servers.

Reproducible: Always
Steps to Reproduce:
1. Write two mails on two different accounts for sending them via two different
smtp servers.
2. Assign the account of the first mail to a smtp server which is not
reachable/not existent/firewalled
3. Send the mails from Unsent Messages

Actual Results:  Mozilla gets an error while trying to send the first mail and
stops sending.

Expected Results:  Should continue sending the second one (or just try it).

Comment 1

[Christian Eyrich]

Attachment: proposed patch

If sending a message succeeds, StartNextMailFileSend() will be called from the
notification handler SendOperationListener::OnStopCopy after doing FCC and
deleting the sent mail from unsent messages folder.
This doesn't happen if sending the mail fails and the send operation stops.


I've done a little patch now. It calls StartNextMailFileSend() from
SendOperationListener::OnStopSendinge in case of an error.

I'm not sure if this new way is very nice and clean. Maybe we should directly
jump into StartNextMailFileSend() from the if (NS_FAILED(aExitCode)) in
nsMsgComposeAndSend::DoDeliveryExitProcessing.


   Attention, this patch competes with the patch to bug 154184 (see comment
#3). The menu entry will not be disabled even if messages fail to be sent as
soon as all messages will be tried to sent.

But since I'm not sure if this patch is really good, I posted the other one
nevertheless.

Comment 2

[Christian Eyrich]

*** Bug 197912 has been marked as a duplicate of this bug. ***

Comment 3

[Tobias Herp]

Confirming this bug for Mozilla/5.0 (Windows; U; Windows NT 5.1; de-AT; rv:1.6)
Gecko/20040113:

I have four message in my unsent messages folder. When going online, one message
can't be sent: the server returns "5.7.0 {mp021} Sender address does not belong
to logged in user". Mozilla doesn't give me a clue which message yields this
error, and all messages stay in the the unsent folder.

Comment 4

[Wayne Mery (:wsmwk)]

does this problem still occur?  (I can't test at present, don't have more than one smtp server)

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #4)
> does this problem still occur?  (I can't test at present, don't have more than
> one smtp server)

Still an issue.

Comment 7

[Suyash Agarwal (:sshagarwal)]

I think this issue doesn't exist anymore. I followed the STR and the false server gave the error while, the working server was able to send the mail.

Comment 8

[Suyash Agarwal (:sshagarwal)]

So, shall we close this bug?

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to Suyash Agarwal (:sshagarwal) from comment #7)
> I think this issue doesn't exist anymore. I followed the STR and the false
> server gave the error while, the working server was able to send the mail.

sshagarwal, thanks for testing!