154184 - Send Unsent msgs disabled after 1 failure

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[Susie Wyshak]

Using Gecko/20020620 trunk on Win2K.

To replicate:
-Have unsent messages set up
-Select to send them while in a setup that will fail. For me this occured twice
today:
   1) I had the wrong SMTP server selected in my default mail, thus sending
Unsent failed
   2) I tried changing the SMTP server to the right one but SEnd Unsent was disabled

Expected: I can select Send Unsent until the messages finally send.
It's also expected that only 1 copy will be sent, no matter how many times I try
to send Unsent messages and fail.

Comment 1

[Christian Koch]

OS: Linux
Mozilla 1.1

Can confirm that: When I'm trying to send unsent messages while not connected to
the internet "send unsent messages" gets disabled. I have to restart the
Mail-Client to sent my messages.

Comment 2

[grylchan]

*** Bug 151373 has been marked as a duplicate of this bug. ***

Comment 3

[Christian Eyrich]

Attachment: proposed patch

Mozilla evaluates on the fly if it enables or disables the menu entry in
IsSendUnsentMsgsEnabled (mail3PaneWindowCommands.js). But before testing if any
mails are in the unsent mails folder it tests, if Mozilla is currently sending
any unsent messages.

The problem is, that this flag (mSendingUnsentMsgs in class nsMessenger) isn't
set to false if sending unsent messages fails. The way Mozilla goes if sending
fails is an other than in case of success and the flag remains true.

I've done a little patch now. So SendLaterListener::OnStopSending is now called
via notification in case of an error.


   Attention, this patch competes with the patch to bug 151364 (see comment
#1). If continuing sending messages even if one failed, the flag will be set to
false as soon as all messages have been tried to sent.

But since I'm not sure if my patch to the other bug is really good, I posted
this one nevertheless.

Comment 4

[Christian Eyrich]

*** Bug 197896 has been marked as a duplicate of this bug. ***

Comment 5

[David :Bienvenu]

Comment on attachment 118838 [details] [diff] [review]
proposed patch

sr=bienvenu, seems like the right thing to do.

Comment 6

[David :Bienvenu]

re-assigning to Christian.

Comment 7

[David :Bienvenu]

marking fixed - I fixed the brace style (this file does not use K&R) and fixed
some unrelated PR_FREEIF's to use PR_Free, and checked this in.

Comment 8

[Mike Cowperthwaite]

*** Bug 106539 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Cowperthwaite]

*** Bug 154494 has been marked as a duplicate of this bug. ***