1513718 - There's no option to import passwords from Chromium on Linux

Status: NEW

(Firefox :: Migration, enhancement, P2)

Description

[zyx870]

Attachment: NoPasswordOption.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/71.0.3578.80 Chrome/71.0.3578.80 Safari/537.36

Steps to reproduce:

I tried to import my saved passwords from Chromium to Firefox in Ubuntu (Bionic Beaver). Other users have mentioned the same problem here. https://askubuntu.com/questions/981466/import-passwords-from-chrome-to-firefox-quantum-doesnt-work


Actual results:

Only Cookies, Browsing History, and Bookmarks were available as import options.


Expected results:

It should show the option to import passwords.

Comment 1

[Hari KT]

Importing Passwords is a must to have. I have used https://github.com/louisabraham/ffpass to import. But spend more time to make this happen. Searching how to export passwords to csv and then import via ffpass .

ffpass is not easy to install. It needs pip which supports python3 . So it would be really nice feature for people to start trying firefox itself .

Comment 2

[David Schneider]

I can confirm that the following issue has made Mozilla Firefox bothersome to deal with for the last couple of days. This was of course caused by the inability to to import my several hindered password list, thus forced me to search up the desired password, for the website I found myself located at, from Chromium and later sign in on that website while using Firefox.

I hope this issue will be resolved as soon as possible!

Comment 3

[Matthew N. [:MattN]]

I can mentor someone on implementing this if they are interested. You can use https://phabricator.services.mozilla.com/D64713 and https://phabricator.services.mozilla.com/D58203 as references to which files need to be changed.

Some docs are at https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Comment 4

[David Schneider]

(In reply to Matthew N. [:MattN] (PM me if request are blocking you) from comment #3)

I can mentor someone on implementing this if they are interested. You can use https://phabricator.services.mozilla.com/D64713 and https://phabricator.services.mozilla.com/D58203 as references to which files need to be changed.

Some docs are at https://firefox-source-docs.mozilla.org/contributing/how_to_contribute_firefox.html

Due to the lack of programming skills required by me to implement the following feature, I would kindly appreciate it if a skillful programmer could implement this feature instead!

Comment 5

[Obayagbona Uwagbae Alexander]

I would like to try implementing this feature

Comment 6

[Matthew N. [:MattN]]

Awesome! Let me know if you need more info than comment 3.

Comment 7

[Obayagbona Uwagbae Alexander]

Thank you!
I'll look through those patches and try to understand them.
I have a local copy of the repo so I can do tests locally. I use Ubuntu 18.04LTS.

Comment 8

[Matthew N. [:MattN]]

Hello, how are things going with this patch?

Comment 9

[Obayagbona Uwagbae Alexander]

Good day, I haven't made much progress unfortunately.
I'm still trying to understand the 2 patches referenced above in comment #3.

Comment 10

[Matthew N. [:MattN]]

OK, well let me know if there is something specific you'd like me to explain.

Comment 11

[Obayagbona Uwagbae Alexander]

Good day, I have some questions. Is there a platform I can ask them on or email so I don't populate this bug with comments or you'd prefer I asked them here?

Comment 12

[Matthew N. [:MattN]]

Hello, you can ask questions here or in live chat: https://matrix.to/#/!rULHhrUvckJYfNKouF:mozilla.org?via=mozilla.org&via=matrix.org&via=chat.haugk.ag

Comment 13

[Matthew N. [:MattN]]

The main issue is that we need to do the decryption starting at https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/browser/components/migration/ChromeProfileMigrator.jsm#501-518

Look at the Chromium code to understand the encryption used. It looks like there are actually two used (v10 and v11) so this bug should probably focus on one of them and the other can be done in a follow-up. Definitely only do one per commit.

To start I would try get the decryption unit test working:

• https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/browser/components/migration/tests/unit/test_Chrome_passwords.js#250-251
• https://searchfox.org/mozilla-central/rev/25d491b7924493b5d4bedc07841a1cd92f271100/browser/components/migration/tests/unit/xpcshell.ini#17,19

Then you can make the UI appear in a separate commit once the above is working.

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:Gijs, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 15

[Oana Botisan, Desktop QA]

This issue is reproducing for Opera and Vivaldi while using the latest Nightly 110.0a1 on Ubuntu 18.04 x64.

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.