1513854 - Read Normandy recipes from Remote Settings

Status: VERIFIED FIXED

(Firefox :: Normandy Client, enhancement)

Description

[Mathieu Leplatre [:leplatrem]]

In Bug 1506175, we introduced the ability to fetch recipes from Remote Settings. 

The pref "app.normandy.remotesettings.enabled" is false by default.

We could gradually enable this feature once the server parts are in place.

Comment 1

[Mathieu Leplatre [:leplatrem]]

The Data Science ticket for the progressive rollout using Feature Gate for Fx 67 is Bug 1533030

I suggest that we use this ticket to enable it by default in Fx 68

Comment 2

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1513854 - Read Normandy recipes from Remote Settings on Nightly

Read Normandy recipes from Remote Settings by default

Comment 3

[Mathieu Leplatre [:leplatrem]]

Mike, how should we proceed now that Bug 1538248 landed?

Can we use Feature Gates to enable it for Nightly users? (Leaving the default setting to false)
Or shall we set default to false in Nightly only using #ifdef RELEASE_OR_BETA in the prefs file?

In terms of QA, I'd imagine that we can take an existing test plan and just add the pref flip parts...

Comment 4

[Michael Cooper [:mythmon]]

I thought about this a bit, and realized we have a small bug in how feature gates manage prefs. I filed (and added a patch for) bug 1541469 for that issue. Once that is done, we should be able to turn this on for Nightly users only by updating the feature definition to have:

default-value:
  default: false
  nightly: true

Then later when we want to turn this on for all channels and let it ride the train, we can update it again to be

default-value: true

Additionally, QA will be able to test this by setting the pref to true. After bug 1541469 they'll need to add the pref, as it won't exist by default.

Comment 5

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=90bd702a3db7f0d9afa762308989f422cc57d17b

Comment 6

[Mathieu Leplatre [:leplatrem]]

Ciprian, how does it look on the QA side?

Mike, does the patch seem ok?

Comment 7

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4722646312bfab234a14fd3f3d6f654d70b3879e

Comment 8

[Michael Cooper [:mythmon]]

The patch looks good.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b66e9b91074
Read Normandy recipes from Remote Settings on Nightly r=mythmon

Comment 10

[Stefan Hindli [:stefan_hindli]]

Backed out 2 changesets (Bug 1535056, Bug 1513854) for linux build bustages and failed Gecko Decision Task CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=244114623

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244114623&repo=autoland&lineNumber=36549

Comment 11

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd990ee93c08e87b5351cf3cd086d3b0b306c392

Comment 12

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d5da6d732eb41b2021e5e893ed94a65392c24327

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e111da82652
Read Normandy recipes from Remote Settings on Nightly r=mythmon

Comment 14

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/4e111da82652

Comment 15

[Michael Cooper [:mythmon]]

Looks like Mathieu took care of my ni?

Comment 16

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Removing the ni? as we signed off on the feature as GREEN.