1513915 - LSNG: LoadItem could return more items (up to the prefill limit)

Status: RESOLVED FIXED

(Core :: Storage: localStorage & sessionStorage, enhancement, P2)

Description

[Jan Varga [:janv]]

We currently use the prefilling only when a snapshot is being synchronously created. Later when we need an item that is not in the initial snapshot prefill, we have to call SendLoadItem to load it. This can be improved even more by loading other items that are not immediately needed. We can use the same prefill pref for that (16 KB). This should lower down number of sync IPC messages, especially when we operate on bigger databases and JS involving complex/many database operations done during one micro task.

Comment 1

[Jan Varga [:janv]]

I've implemented this and I see some interesting performance improvements on raptor tp6 tests:

Optimization + prefill reduced to 8KB:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0c6089e3645e4ee260a6f1938a3262537680f8c
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=a0c6089e3645e4ee260a6f1938a3262537680f8c&framework=10&selectedTimeRange=604800

Optimization + prefill reduced to 4KB:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0432ca9659e3a15b1d98066574346832939c4367
https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=0432ca9659e3a15b1d98066574346832939c4367&framework=10&selectedTimeRange=604800

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1513915 - LSNG: LoadItem could return more items (up to the prefill limit); r=asuth

Comment 3

[Jan Varga [:janv]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e39a44dc2d88ba1b8332c4bff30a60b82179f501

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a64a71ccebf7
LSNG: LoadItem could return more items (up to the prefill limit); r=asuth,jld

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1513915 - Followup patch to increase requesttimeoutfactor for test_snapshotting.js; r=asuth

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95ccc600e533
Followup patch to increase requesttimeoutfactor for test_snapshotting.js; r=asuth

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a64a71ccebf7
https://hg.mozilla.org/mozilla-central/rev/95ccc600e533

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.