Identify tests failing with the Quantum Bar

RESOLVED FIXED in Firefox 66

Status

()

P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: mak, Assigned: standard8)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(3 attachments)

(Reporter)

Description

3 months ago
We must get a full list of all the tests that will fail when we switch on the quantumbar pref, those tests should be moved into a legacy folder in the urlbar component so that we can switch them on/off based on the quantum bar pref, and then ported to the new codebase.
(Reporter)

Updated

3 months ago
Priority: P1 → P2
(Assignee)

Updated

2 months ago
Depends on: 1521043
(Assignee)

Comment 1

2 months ago

Note: in bug 1521043, I'm going to move all the existing urlbar tests that we know of (without digging), into the legacy directory.

We can then work through them to work out which needs porting etc.

(Assignee)

Comment 2

2 months ago

Changed my mind, lets just do this.

Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: P2 → P1
(Assignee)

Comment 4

2 months ago

This moves the tests to browser/components/urlbar and sets them up for running both against QuantumBar as well as the legacy address bar.

Depends on D16995

(Assignee)

Comment 5

2 months ago

Try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cee5c6247e57759dd08e06616113433ede3447a1

For context:

  • .ini files now let you set prefs for the test to run (not sure if its is just per dir or per test but we're using it in the dir scope)
  • the plan is to have tests/browser which runs quantumbar=true and tests/legacy with quantumbar=false
  • Since you can also reference tests in other directories, tests/legacy references all the legacy tests, plus the ones in tests/browser which are compatible with the old urlbar.
  • The minor possible downside is if you run one specific test it’ll run it twice (once with the pref true, once false), but that could also been seen as an advantage.

Currently the files are where they are most compatible with - tests/browser if they run with quantumbar, legacy otherwise. We can move them across as we go.

Additionally, at the moment, tests/browser fails with quantumbar=true. I think that's because we haven't quite fixed something we should have, and I'm looking into it. I might do that toggle in a third changeset or a follow-up bug, depending on when it is ready, reviews etc.

(Reporter)

Comment 6

2 months ago

IS this commented out?

BROWSER_CHROME_MANIFESTS += [
'tests/browser/browser.ini',
# 'tests/legacy/browser.ini',
]

(Assignee)

Comment 7

2 months ago

Bah, yes. Shouldn't have been, I was testing something locally and left it in by mistake.

New try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3af25c5560b57fc07060fc5aaf82161858fe72e9

(Reporter)

Updated

2 months ago
Blocks: 1520494
(Reporter)

Updated

2 months ago
Blocks: 1520839
(Assignee)

Updated

2 months ago
Blocks: 1521490
(Assignee)

Comment 8

2 months ago

Although these tests are all able to pass individually, some still fail when run together. Bug 1521490 will address those.

Depends on D16996

(Assignee)

Updated

2 months ago
Blocks: 1521513
(Assignee)

Updated

2 months ago
Blocks: 1521532
(Assignee)

Updated

2 months ago
Blocks: 1521534
(Assignee)

Comment 10

2 months ago

Last try push that included disabling a few tests due to shutdown leaks: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7159404735d7c289ca86d8158100abae280b0b24

Comment 11

2 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ba9f9c0ce256
Change urlbar tests to use the test path rather than hard-coding it. r=mak
https://hg.mozilla.org/integration/autoland/rev/306a66424aad
Move urlbar tests to the new urlbar directory and split out tests that already pass with QuantumBar. r=mak
https://hg.mozilla.org/integration/autoland/rev/3ee7a4b57a9a
Enable running some of the urlbar tests against QuantumBar. r=mak

Comment 12

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
(Assignee)

Updated

2 months ago
Blocks: 1521707
You need to log in before you can comment on or make changes to this bug.