1514354 - Add support for --gecko-profile when running Raptor tests on android (geckoview)

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P2)

Description

[Robert Wood [:rwood]]

Same as we already have for --gecko-profile when running on Firefox desktop.

Comment 1

[Markus Stange [:mstange]]

I recommend the following settings:
features: ["js", "stackwalk", "responsiveness"]
threads: ["GeckoMain", "Compositor"]
interval: 10
buffer size: not sure, you may need to play with this a little. too large values will make it crash, short values will truncate the profile. You may not be able to fit more than 20 seconds or so of runtime into the buffer.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

After looking into this I realized that actually the gecko profiler was working properly before Bug 1835065 on Android. But looks like it added some self.config["app"] == "firefox" checks for profiling parts. That removed the android support because self.config["app"] is either "fenix" or "geckoview". So we should bring it back.

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1514354 - Rename FIREFOX_ANDROID_APPS to ANDROID_APPS r?#perftest

FIREFOX_ANDROID_APPS was incorrectly named because it also include chrome
android app. That's why to make it clear, I renamed it to ANDROID_APPS.

I wanted to make this change, so I can introduce a FIREFOX_APPS constant in
the following patch.

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1514354 - Enable the gecko profiler on Android Firefox raptor tests r?kshampur!,#perftest

It looks like we had support for Android before but since the Bug 1835065, we
lost this feature. This is because it looks like we added some
self.config["app"] == "firefox" checks to profiler related code and firefox
for android has different app name (like "geckoview" or "fenix").

This patch brings back the android profiling by changing those if checks to
include the android firefox adds as well.

Depends on D187665

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/291b2b068eff
Enable the gecko profiler on Android Firefox raptor tests r=kshampur,perftest-reviewers

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/291b2b068eff