1835065 - Add support for gathering a Chrome desktop profile in Raptor

Status: RESOLVED FIXED

(Testing :: Raptor, enhancement, P1)

Description

[Kash Shampur [:kshampur] ⌚EST]

For investigating where there are differences in performance between Firefox and Chrome, it would be valuable to capture a Chrome trace and provide a convenient way to open this in the Firefox Profiler.

We can use the browsertime commands for running a trace.
And we can follow a similar approach to Bug 1786400 for implementing it in raptor

For starters we should just get this on chrome/chromium first, then later custom-car in a follow up bug

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

We would probably also have to make changes upstream in browsertime (like in Bug 1823730) if we want to profile benchmarks the same way

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

quick update with some example pageload trace
https://treeherder.mozilla.org/jobs?repo=try&tier=1%2C2%2C3&revision=9c1482244b45890a8c5982722f6cad5c9e6ff6dd

direct link to e.g. wikipedia cold trace

Comment 3

[Kash Shampur [:kshampur] ⌚EST]

seems to work on chromium and custom-car as well? Perhaps I misunderstood these symbol flags for CaR, maybe they are not required for traces (in my head i related the symbols to symbolication). Will revisit the flags when the time comes, if even necessary (best case they are not required, because enabling them increases the build time!)

Comment 4

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835065 - Add support for gathering a Chrome desktop profile in Raptor. r?#perftest

Comment 5

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835065 - Add tests for chrome extra profiler run. r?#perftest

Here tests are added for manifest and another to test the archiving from
a trace run in browsertime.

Depends on D183894

Comment 6

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835065 - Add a super class for profiling in raptor-browsertime. r?#perftest

This patch refactors slightly the chrome trace class to begin using a
raptor profling superclass. This is due to the overlap between the
ChromeTrace class and the GeckoProfile class. This patch doesn't
complete the entire refactoring process but lays a foundation to follow
up on it.

Depends on D185430

Comment 7

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835065 - Add brief description of Chrome trace support in documentation. r?#perftest

This patch adds some explanation of the current support of tracing in
raptor-browsertime and clarifies that this currently only supports
pageload tests. This documentatoin will be further extended once
benchmark support is added.

Depends on D185961

Comment 8

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835065 - Add a super class for profiling in raptor-browsertime. r?#perftest

This patch refactors slightly the chrome trace class to begin using a
raptor profling superclass. This is due to the overlap between the
ChromeTrace class and the GeckoProfile class. This patch doesn't
complete the entire refactoring process but lays a foundation to follow
up on it.

Comment 9

[Kash Shampur [:kshampur] ⌚EST]

Attachment: Bug 1835065 - Subclass raptor gecko profile class with new superclass. r?#perftest

This patch slightly refactors the gecko profile class in
raptor-browsertime to make use of the new RaptorProfiling superclass.

Depends on D185962

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b5fa5a243ad
Add a super class for profiling in raptor-browsertime.  r=perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/9c4e4b0f883b
Add support for gathering a Chrome desktop profile in Raptor. r=perftest-reviewers,sparky,canaltinova
https://hg.mozilla.org/integration/autoland/rev/195ebef7dcd7
Add tests for chrome extra profiler run. r=perftest-reviewers,canaltinova,sparky
https://hg.mozilla.org/integration/autoland/rev/c605479083e1
Add brief description of Chrome trace support in documentation. r=perftest-reviewers,sparky
https://hg.mozilla.org/integration/autoland/rev/e3e4e48f102f
Subclass raptor gecko profile class with new superclass. r=perftest-reviewers,sparky

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9b5fa5a243ad
https://hg.mozilla.org/mozilla-central/rev/9c4e4b0f883b
https://hg.mozilla.org/mozilla-central/rev/195ebef7dcd7
https://hg.mozilla.org/mozilla-central/rev/c605479083e1
https://hg.mozilla.org/mozilla-central/rev/e3e4e48f102f