Closed Bug 1514993 Opened 6 years ago Closed 6 years ago

Legacy addons overlay loader errors with relative URIs in script tags

Categories

(Thunderbird :: Add-Ons: General, defect)

Product:
Thunderbird
Component:
Add-Ons: General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird65 fixed, thunderbird66 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 66.0
Tracking Flags:
Tracking Status
thunderbird65 --- fixed
thunderbird66 --- fixed

People

(Reporter: dave, Assigned: darktrojan)

References

Details

Attachments

(1 file)

1514993-overlay-relative-ref-1.diff
1.95 KB, patch
Fallen
: review+
jorgk-bmo
: approval-comm-beta+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:63.0) Gecko/20100101 Firefox/63.0 Steps to reproduce: See https://bugzilla.mozilla.org/show_bug.cgi?id=1476259#c14 Legacy addons overlay loader generates "Error creating URI (invalid URL scheme?)" Replacing e.g. <script type="application/x-javascript" src="namespace.js"/> with <script type="application/x-javascript" src="chrome://usebccinstead/content/namespace.js"/> fixes it. Should block bug 1476259 - see https://bugzilla.mozilla.org/show_bug.cgi?id=1476259#c15
Blocks: 1476259
Assignee: nobody → geoff
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9032385 - Flags: review?(philipp)
Attachment #9032385 - Flags: review?(philipp) → review+
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/92f2f9d3268c Resolve overlays' script/stylesheet references relative to the overlay; r=Fallen
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 66.0
Attachment #9032385 - Flags: approval-comm-beta?
Attachment #9032385 - Flags: approval-comm-beta? → approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: