1515061 - Consider pinned tabs when deciding whether to warn before quitting

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, enhancement, P3)

Description

[Siddhartha]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

This is a followup from https://bugzilla.mozilla.org/show_bug.cgi?id=550559#c82. With session restore + warn on quit enabled, I tried quitting the browser using Ctrl+Q when I have multiple windows with all open tabs pinned.


Actual results:

The browser quit without warning.


Expected results:

The browser should have warned that there are open pinned tabs.

Comment 1

[Siddhartha]

Can I bring some attention to this bug? It's rare enough to not usually bother, but is quite annoying when it does happen (only pinned tabs are open).
I imagine the fix will be relatively simple.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 10 votes.
:dao, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 3

[fahd777]

The issue causing this bug was just closed: https://bugzilla.mozilla.org/show_bug.cgi?id=1717752

Unsure if the mechanism by which the warning is triggered is still based on counting tabs or not.

Comment 4

[Siddhartha]

I think this bug bug can be closed now. I tried quitting with all pinned tabs and Firefox warns appropriately with single or multiple windows before quitting.