426849 - No quit confirmation when only one single tab is open. Too easy to Ctrl-Q and exit/close.

Status: NEW

(Firefox :: General, defect)

Description

[aaa]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008032619 Firefox/3.0b5

Apparently CTRL+Q quits now, when it didn't before. I'd be trying to hit W and instead hit Q. No prompt pops up. browser.warnOnExit=true already

It should show one prompt. It's nice that it doesn't show one for every tabbed window like FF2 did, but just silently quitting right way isn't good.

Reproducible: Always

Steps to Reproduce:
1. Press CTRL+Q
2.
3.
Actual Results:  
Quits without a prompt.

Expected Results:  
A confirmation dialog should pop up.

Comment 1

[[:Aleksej]]

Confirmed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9pre) Gecko/2008041404 Minefield/3.0pre.

Comment 2

[Jason Harvey]

User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9pre) Gecko/2008041618 Minefield/3.0pre


When pressing "Ctrl-Q" with multiple tabs open, I do get a dialog box confirming that I do want to quit.

If I have 0 tabs and only 1 window open, Ctrl-Q quits immediately. It this really a problem? If you are trying to press "Ctrl-W" with no tabs and you accidentally hit "Ctrl-Q", you get the exact same result: the browser exits. So I don't believe the typo potential is an issue.

If you do only have 1 window open with no tabs, and you do intend to press "Ctrl-Q", then is a confirmation dialog really necessary?

The only advantage to the Quit dialog with no tabs  would be that you have the option to "Save and Close", or simply "Close". That is a legitimate need and I could see it as being quite useful. If a user wanted to speed up the closing process, they could simply check the "do not ask me next time" option in the quit dialog.


I guess the main question is should the browser treat a "Quit" request differently if the browser is only running with 1 window and no tabs?

Comment 3

[Jason Harvey]

Attachment: Enables browser quit dialog box, even if only 1 page is opened

This will cause the browser to display the Quit dialog box when only 1 page page opened.

This gives the user the option to "Save and Quit" so that they can return where they left off, even if they don't have multiple tabs/windows opened. Users wishing to speed up the quit process can simply select "Do not ask me again".

There are pros and cons to this, and it definitely merits more discussion before moving forward.

Comment 4

[aaa]

Now I think it's an extension problem (oops)...
It is quitting without confirmation with several tabs open.

On the current topic (should it show a confirmation for only one tab), there shouldn't be a confirmation for that (which is what it does). Maybe an option for it, but making it do so by default would be annoying.

Comment 7

[Richard Neill]

This is a duplicate of Bug 52821, which was opened in 2001 (and finally closed last year, but it seems to be back). Seriously, who needs a shortcut command for "please throw away my data"?

Comment 8

[anonyhole]

(In reply to comment #2 and comment #7)

> 
> If you do only have 1 window open with no tabs, and you do intend to press
> "Ctrl-Q", then is a confirmation dialog really necessary?

Yes, per the use case you describe below.  If one wants to close a window (and suppose I do not know how many others are open), one uses CloseWindow.  If one wants to either A) close all windows or B) quit+save-session, then one uses Quit/Exit.

> 
> The only advantage to the Quit dialog with no tabs  would be that you have the
> option to "Save and Close", or simply "Close". That is a legitimate need and I
> could see it as being quite useful. If a user wanted to speed up the closing
> process, they could simply check the "do not ask me next time" option in the
> quit dialog.

I certainly have this use case where I use File-->Quit (Ctrl+Q) specifically to give me the option of saving the session this time.

I do not always want to save my sessions (that's why I don't have it as the startup preference).

I often have one window, with one tab only, that I consider a valid "session" that I would like to return to.  Only having one page does not make easier to find/remember that page again next time.


I can confirm that this bug still exists on:
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.0.10) Gecko/2009042523 Ubuntu/9.04 (jaunty) Firefox/3.0.10


Also, @Richard Neill, Comment #7 : I am having a hard time interpreting your last comment: "Seriously, who needs a shortcut command for 'please throw away my data'?"  I am not sure what it is suggesting.  I cannot tell specifically what feature/command/process/etc you are in favor of or against.  Please clarify your argument -- I apologize if I am dense! Thanks, :-).

Comment 9

[Richard Neill]

Sorry, I wasn't very clear in Comment #7. I've hated the Ctrl-Q misfeature for such a long time now!. What I'm arguing is that Ctrl-Q should either be completely unbound, or bound to "quit, with confirmation". 

Quitting from the file menu (or even the Window close button, or Alt-F4) is a positive intent from the user. Whereas I find that, because I use Ctrl-W repeatedly, I may hit Ctrl-Q accidentally on occasion (though I _never_ do so deliberately). [Furthermore, Ctrl-W can be undone, thanks to TabMixPlus, but Ctrl-Q cannot.]

Alternatively, can I suggest that the data-loss-causing keyboard shortcuts should at least be something harder to type (compare: Ctrl-Alt-Del; Alt-SysRq-B;
or "ESC : Q !" )

Comment 10

[Wayne Mery (:wsmwk)]

with session restore, this is no longer dataloss

Comment 11

[Fabien]

There may be some dataloss in some extensions and login states. For example, with lastpass, you need to re-log each time you start firefox. Since i'm often closing it by mistake, i'd love a quit confirmation :)

Comment 12

[icewater]

This is one of those glaringly obvious terrible usability issues that for some mysterious reason lingers on, and on, and on for years.

Comment 13

[Ben Bangert [:benbangert]]

Just an update, this bug still exists, and will actually fail to show you the dialog if you have other windows/tabs open, but run the Quit command in a window with just 1 tab open. Ideally the confirmation should take into account all windows/tabs, and not just the one you happen to be on.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This has recently changed with bug 1438499, yet the bug is still valid. See discussion in bug 1438499 comment 5.

I highly suspect this is a bug that is a duplicate of a bug mentioned there.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 4 duplicates and 10 votes.
:mossop, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 18

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 19

[Terry Vasquez]

Attachment: dedownglycop19713996.txt

Thanks from zygatopanch1974.