1515078 - Add opt in/out UX for Pocket+New Tab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Comment 1

[pcho]

The wireframe mocks have a few different versions, the latest is the "v3" page.

Attaching a screenshot in case.

Comment 2

[pcho]

Attachment: Mocks for the opt out UX/UI

Comment 3

[Kate Hudson :k88hudson]

Attachment: GitHub Pull Request

Comment 4

[Andrei Oprea [:andreio]]

Attachment: Bug 1515078 - Add opt out UX in about:preferences for Pocket Newtab

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/35b5b9a35de3e8324100d5c11969a9a975c62753
Bug 1515078 - Add opt out UX in about:preferences for Pocket Newtab (#4642)

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8de26a67ac5c

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4677

Comment 8

[Kate Hudson :k88hudson]

Steps to test:

1. Set browser.newtabpage.activity-stream.discoverystream.config pref to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"} in about:config
2. Go to about:preferences#home
3. Ensure you see a "Turn off content" button in the Firefox Home section
4. Click it. Ensure you no longer see the pocket new tab experiment on existing tabs and new tabs

Comment 9

[Brahmini Nagabandi]

Test Results:

Verified on :

FF Nightly Version - 66.0a1 (2019-01-17)

OS - Mac / Windows 10 Pro N

Looks good to me.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e975e4b3558
Add opt out UX in about:preferences for Pocket Newtab r=Mardak

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/2a4c65cd29867fdd152a03bf6fe2cd9a9eb05d76
Bug 1515078 - Use PreferenceExperiments API to unenroll from Pocket Newtab experiment (#4677)

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/3e975e4b3558

Comment 13

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/381457de43c0

Comment 14

[Brahmini Nagabandi]

Re-testing this bug due to new implementation changes.

Comment 15

[Brahmini Nagabandi]

Test Failed. After QA steps, New Tab experiment doesn't switch back to default experience.

QA Results:

Tested on :

FF Nightly Version : 66.0a1 (2019-01-22)

OS : Mac , Windows 10 Pro

Steps to Reproduce:

1. Go to about:config and Set browser.newtabpage.activity-stream.discoverystream.config pref to {"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
2. Go to about:preferences#home
3. Ensure you see a "Turn off content" button in the Firefox Home section
4. Click Turn off content--> Open New Tab and also check already opened New Tab

Actual Result :
New Tab experience persists.

Expected Result:
Default new tab version on existing tabs and new tabs is expected.

Comment 16

[Andrei Oprea [:andreio]]

This is expected behavior. We check if the user is enrolled in an experiment in order to properly remove them but we optimistically change the UI in about:preferences if the pref is turned on and when you click the button to disable.
I will be working on a method to fake enrollment through asrouter-debuger so we can properly test this feature.

Comment 17

[Brahmini Nagabandi]

Is there a separate bug you’re tracking for the method that you’ve mentioned, so this bug can be closed.

Comment 18

[Andrei Oprea [:andreio]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1522551

Comment 19

[Brahmini Nagabandi]

Closing as verified.