Add opt in/out UX for Pocket+New Tab
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: andreio, Assigned: andreio)
References
Details
(Keywords: github-merged)
User Story
Attachments
(4 files)
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Updated•6 years ago
|
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
•
|
||
Steps to test:
- Set
browser.newtabpage.activity-stream.discoverystream.config
pref to{"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
in about:config - Go to about:preferences#home
- Ensure you see a "Turn off content" button in the Firefox Home section
- Click it. Ensure you no longer see the pocket new tab experiment on existing tabs and new tabs
Comment 9•6 years ago
|
||
Test Results:
Verified on :
FF Nightly Version - 66.0a1 (2019-01-17)
OS - Mac / Windows 10 Pro N
Looks good to me.
Comment 10•6 years ago
|
||
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
bugherder |
Comment 13•6 years ago
|
||
Comment 14•6 years ago
|
||
Re-testing this bug due to new implementation changes.
Comment 15•6 years ago
|
||
Test Failed. After QA steps, New Tab experiment doesn't switch back to default experience.
QA Results:
Tested on :
FF Nightly Version : 66.0a1 (2019-01-22)
OS : Mac , Windows 10 Pro
Steps to Reproduce:
- Go to about:config and Set
browser.newtabpage.activity-stream.discoverystream.config
pref to{"enabled":true,"layout_endpoint":"https://getpocket.com/v3/newtab/layout?version=1&consumer_key=40249-e88c401e1b1f2242d9e441c4&layout_variant=dev-test-1"}
- Go to about:preferences#home
- Ensure you see a "Turn off content" button in the Firefox Home section
- Click
Turn off content
--> Open New Tab and also check already opened New Tab
Actual Result :
New Tab experience persists.
Expected Result:
Default new tab version on existing tabs and new tabs is expected.
Assignee | ||
Comment 16•6 years ago
|
||
This is expected behavior. We check if the user is enrolled in an experiment in order to properly remove them but we optimistically change the UI in about:preferences if the pref is turned on and when you click the button to disable.
I will be working on a method to fake enrollment through asrouter-debuger so we can properly test this feature.
Comment 17•6 years ago
•
|
||
Is there a separate bug you’re tracking for the method
that you’ve mentioned, so this bug can be closed.
Updated•6 years ago
|
Assignee | ||
Comment 18•6 years ago
|
||
Updated•5 years ago
|
Description
•