15155 - Dropping down comboboxes causes reflow

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P4)

Description

[Peter Linss]

This is due to the use of 'visibilty' collapse. I have an optimization I can
make once box frames stop using collapse for reflow purposes.

Comment 1

[Peter Linss]

The code in StyleDisplayImpl::CalcDifference for visibility should only return
NS_STYLE_HINT_REFLOW if the mDisplay is table row or table col.
This needs still needs to be reconciled with nsBoxFrame's usage of collapse
first.

Comment 2

[leger]

Moving [DOGFOOD] in Status Summary to dogfood in keyword field.

Comment 3

[leger]

Old bug, still a problem.  for dogfood?

Comment 4

[Phil Peterson]

PDT-

Comment 5

[Pierre Saslawsky]

*** Bug 29605 has been marked as a duplicate of this bug. ***

Comment 6

[rickg]

Moving crufty m14-m15 bugs out to m16 for proper triage.

Comment 7

[leger]

Putting on [dogfood-] radar.

Comment 8

[buster]

*** Bug 31257 has been marked as a duplicate of this bug. ***

Comment 9

[buster]

transferring perf keyword and cc list from dup'd bug 31257

Comment 10

[Marc Attinasi]

Pierre pique'd my interest in this one, so I added myself to the CC list. I'll 
try to contribute some ideas based on Pierre's prior efforts soon.

Comment 11

[Pierre Saslawsky]

Block moved M17 bugs to mozilla0.9

Comment 12

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 13

[Pierre Saslawsky]

It doesn't seem to be a problem anymore.  We'll check it out for a future 
milestone.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think this is based on misuse of the meaning of 'visibility: collapse', which
should generally cause a reflow (based on what it means for tables, which is the
only thing it really applies to in the CSS spec).

One possible improvement, though, would be to have ComputeDisplayData change
'collapse' to 'hidden' in some cases.  It seems a bit odd to poke at other
structs in CalcStyleDifference.

Is this still an issue for comboboxes?  I suspect not, and even if it is it's
unlikely to be once XBL form controls are turned on.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Assigning pierre's remaining Style System-related bugs to myself.

Comment 16

[Kai Lahmann (is there, where MNG is)]

this page has enough comboboxes to test, but I don't see any (visible) reflow..?!

Comment 17

[Markus Hübner]

Is this bug still valid at all?

Comment 18

[Boris Zbarsky [:bzbarsky]]

We seem to handle this by hiding or showing the popup view now... jkeiser?  roc?
 Could you verify that please?

Comment 19

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I don't think 'visibility:collapse' is used for the dropdown anymore.