Need doorhanger to announce that extensions no longer run by default in Private Browsing windows

VERIFIED FIXED in Firefox 67

Status

defect
P1
normal
VERIFIED FIXED
4 months ago
3 days ago

People

(Reporter: mconca, Assigned: mixedpuppy)

Tracking

(Depends on 1 bug, Blocks 1 bug)

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 verified)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Reporter)

Description

4 months ago
With release 66, installed extensions will be disallowed from running in private browsing windows.  Users will need to navigate to each extension in the add-ons manager and explicitly grant permission to those extensions they want to run in private browsing.

A doorhanger shown in private windows should contain a brief message explaining the new situation for extensions and directing users to the add-ons manager, if desired.

This doorhanger should be temporary, running for two full release cycles.
(Reporter)

Comment 1

4 months ago
Proposed Mockup:
https://mozilla.invisionapp.com/share/VUPNQNEPWN9#/screens/338029755
Priority: -- → P1
(Assignee)

Comment 2

4 months ago
I will need the icon in svg format.
Flags: needinfo?(emanuela)
(Assignee)

Updated

4 months ago
Assignee: nobody → mixedpuppy
(Assignee)

Comment 4

4 months ago
This is what I have so far on the doorhanger.  Everything works.  I need the icon of course, but more interested whether we want all the choices here.  The learn more link is a bit awkward in xul, it's showing up below the main description.
Attachment #9033475 - Flags: feedback?(mwalkington)
Attachment #9033475 - Flags: feedback?(emanuela)

Comment 5

4 months ago
Since we are able to link directly to the Add-ons Manager from the doorhanger, and the Add-ons Manager will include the message + link to SUMO article, we can remove the "Learn More" link from the doorhanger. Otherwise, this looks good. Thank you.

Comment 6

4 months ago
Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

Since we are able to link directly to the Add-ons Manager from the doorhanger, and the Add-ons Manager will include the message + link to SUMO article, we can remove the "Learn More" link from the doorhanger. Otherwise, this looks good. Thank you.
Attachment #9033475 - Flags: feedback?(mwalkington) → feedback+

Comment 7

3 months ago

The doorhanger looks quite ok! Be sure to align the text at the top (right now it seems like there is an empty row or something like that).

I attached the icon (in SVG) at the bug.

Flags: needinfo?(emanuela)

Comment 8

3 months ago

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

Updated

3 months ago
Attachment #9033475 - Flags: feedback?(emanuela)
Attachment #9033475 - Flags: feedback-
(Assignee)

Comment 9

3 months ago

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #8)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

This is the color for the primary button on all popup notifications so it would be a global style change, something I'd rather have dealt with as a style issue for firefox.

Flags: needinfo?(emanuela)
(Assignee)

Comment 10

3 months ago
Attachment #9033475 - Attachment is obsolete: true
Attachment #9036009 - Flags: feedback?(emanuela)

Comment 11

3 months ago

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #8)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

This is the color for the primary button on all popup notifications so it would be a global style change, something I'd rather have dealt with as a style issue for firefox.

Noted. I will create a new bug for it.

Flags: needinfo?(emanuela)

Comment 12

3 months ago

Comment on attachment 9036009 [details]
private browsing panel

The space between the icon and the text seems slightly off. If this is another global setting, I can follow up in a separate bug.

Attachment #9036009 - Flags: feedback?(emanuela) → feedback+
(Assignee)

Comment 13

3 months ago

(In reply to emanuela [ux] from comment #12)

Comment on attachment 9036009 [details]
private browsing panel

The space between the icon and the text seems slightly off. If this is another global setting, I can follow up in a separate bug.

I compared with the post-install panel, placement is the same, so this is style applied to all the appmenu panels.

Comment 15

3 months ago
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57a6c0ba17d6
show addons disabled doorhanger in private browsing, r=Gijs,flod

Comment 16

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment 17

3 months ago
Posted image Bug1515701.png

This issue is verified as fixed on Firefox 67.0a1 (20190130094929) under Win 7 64-bit and Mac OS X 10.14.1.

At the first visit of the private window, the doorhanger is displayed.

Please see the attached screenshot.

Updated

3 months ago
Status: RESOLVED → VERIFIED

Updated

3 months ago
Depends on: 1523914
You need to log in before you can comment on or make changes to this bug.