Closed Bug 1515701 Opened 4 years ago Closed 4 years ago

Need doorhanger to announce that extensions no longer run by default in Private Browsing windows

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(firefox67 verified)

VERIFIED FIXED
mozilla67
Tracking Status
firefox67 --- verified

People

(Reporter: mconca, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

With release 66, installed extensions will be disallowed from running in private browsing windows.  Users will need to navigate to each extension in the add-ons manager and explicitly grant permission to those extensions they want to run in private browsing.

A doorhanger shown in private windows should contain a brief message explaining the new situation for extensions and directing users to the add-ons manager, if desired.

This doorhanger should be temporary, running for two full release cycles.
I will need the icon in svg format.
Flags: needinfo?(emanuela)
Assignee: nobody → mixedpuppy
Attached image Screen Shot 2018-12-27 at 6.25.56 PM.png (obsolete) —
This is what I have so far on the doorhanger.  Everything works.  I need the icon of course, but more interested whether we want all the choices here.  The learn more link is a bit awkward in xul, it's showing up below the main description.
Attachment #9033475 - Flags: feedback?(mwalkington)
Attachment #9033475 - Flags: feedback?(emanuela)
Since we are able to link directly to the Add-ons Manager from the doorhanger, and the Add-ons Manager will include the message + link to SUMO article, we can remove the "Learn More" link from the doorhanger. Otherwise, this looks good. Thank you.
Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

Since we are able to link directly to the Add-ons Manager from the doorhanger, and the Add-ons Manager will include the message + link to SUMO article, we can remove the "Learn More" link from the doorhanger. Otherwise, this looks good. Thank you.
Attachment #9033475 - Flags: feedback?(mwalkington) → feedback+

The doorhanger looks quite ok! Be sure to align the text at the top (right now it seems like there is an empty row or something like that).

I attached the icon (in SVG) at the bug.

Flags: needinfo?(emanuela)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

Attachment #9033475 - Flags: feedback?(emanuela)
Attachment #9033475 - Flags: feedback-

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #8)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

This is the color for the primary button on all popup notifications so it would be a global style change, something I'd rather have dealt with as a style issue for firefox.

Flags: needinfo?(emanuela)
Attached image private browsing panel
Attachment #9033475 - Attachment is obsolete: true
Attachment #9036009 - Flags: feedback?(emanuela)

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #8)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

This is the color for the primary button on all popup notifications so it would be a global style change, something I'd rather have dealt with as a style issue for firefox.

Noted. I will create a new bug for it.

Flags: needinfo?(emanuela)

Comment on attachment 9036009 [details]
private browsing panel

The space between the icon and the text seems slightly off. If this is another global setting, I can follow up in a separate bug.

Attachment #9036009 - Flags: feedback?(emanuela) → feedback+

(In reply to emanuela [ux] from comment #12)

Comment on attachment 9036009 [details]
private browsing panel

The space between the icon and the text seems slightly off. If this is another global setting, I can follow up in a separate bug.

I compared with the post-install panel, placement is the same, so this is style applied to all the appmenu panels.

Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57a6c0ba17d6
show addons disabled doorhanger in private browsing, r=Gijs,flod
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Attached image Bug1515701.png

This issue is verified as fixed on Firefox 67.0a1 (20190130094929) under Win 7 64-bit and Mac OS X 10.14.1.

At the first visit of the private window, the doorhanger is displayed.

Please see the attached screenshot.

Status: RESOLVED → VERIFIED
Depends on: 1523914
Depends on: 1544975
Depends on: 1554510
See Also: → 1544975
You need to log in before you can comment on or make changes to this bug.