1515701 - Need doorhanger to announce that extensions no longer run by default in Private Browsing windows

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P1)

Description

[Mike Conca [:mconca]]

With release 66, installed extensions will be disallowed from running in private browsing windows.  Users will need to navigate to each extension in the add-ons manager and explicitly grant permission to those extensions they want to run in private browsing.

A doorhanger shown in private windows should contain a brief message explaining the new situation for extensions and directing users to the add-ons manager, if desired.

This doorhanger should be temporary, running for two full release cycles.

Comment 1

[Mike Conca [:mconca]]

Proposed Mockup:
https://mozilla.invisionapp.com/share/VUPNQNEPWN9#/screens/338029755

Comment 2

[Shane Caraveo (:mixedpuppy)]

I will need the icon in svg format.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1515701 show addons disabled doorhanger in private browsing, r?Gijs

Comment 4

[Shane Caraveo (:mixedpuppy)]

Attachment: Screen Shot 2018-12-27 at 6.25.56 PM.png

This is what I have so far on the doorhanger.  Everything works.  I need the icon of course, but more interested whether we want all the choices here.  The learn more link is a bit awkward in xul, it's showing up below the main description.

Comment 5

[Meridel [:meridel]]

Since we are able to link directly to the Add-ons Manager from the doorhanger, and the Add-ons Manager will include the message + link to SUMO article, we can remove the "Learn More" link from the doorhanger. Otherwise, this looks good. Thank you.

Comment 6

[Meridel [:meridel]]

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

Since we are able to link directly to the Add-ons Manager from the doorhanger, and the Add-ons Manager will include the message + link to SUMO article, we can remove the "Learn More" link from the doorhanger. Otherwise, this looks good. Thank you.

Comment 7

[emanuela [ux]]

Attachment: purple-circle-extension.svg

The doorhanger looks quite ok! Be sure to align the text at the top (right now it seems like there is an empty row or something like that).

I attached the icon (in SVG) at the bug.

Comment 8

[emanuela [ux]]

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

Comment 9

[Shane Caraveo (:mixedpuppy)]

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #8)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

This is the color for the primary button on all popup notifications so it would be a global style change, something I'd rather have dealt with as a style issue for firefox.

Comment 10

[Shane Caraveo (:mixedpuppy)]

Attachment: private browsing panel

Comment 11

[emanuela [ux]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #9)

(In reply to emanuela [ux] [OOO 12/21 - 01/07] from comment #8)

Comment on attachment 9033475 [details]
Screen Shot 2018-12-27 at 6.25.56 PM.png

The color for the primary call to action 'Manage Extensions' is off, and it's failing the contrast ratio.

We can fix it by using blue-60 (#0060df).

This is the color for the primary button on all popup notifications so it would be a global style change, something I'd rather have dealt with as a style issue for firefox.

Noted. I will create a new bug for it.

Comment 12

[emanuela [ux]]

Comment on attachment 9036009 [details]
private browsing panel

The space between the icon and the text seems slightly off. If this is another global setting, I can follow up in a separate bug.

Comment 13

[Shane Caraveo (:mixedpuppy)]

(In reply to emanuela [ux] from comment #12)

Comment on attachment 9036009 [details]
private browsing panel

The space between the icon and the text seems slightly off. If this is another global setting, I can follow up in a separate bug.

I compared with the post-install panel, placement is the same, so this is style applied to all the appmenu panels.

Comment 14

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd01417f0b8d53ff1a792e223823d0a24f40d722

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57a6c0ba17d6
show addons disabled doorhanger in private browsing, r=Gijs,flod

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/57a6c0ba17d6

Comment 17

[CosminB]

Attachment: Bug1515701.png

This issue is verified as fixed on Firefox 67.0a1 (20190130094929) under Win 7 64-bit and Mac OS X 10.14.1.

At the first visit of the private window, the doorhanger is displayed.

Please see the attached screenshot.