1516556 - Dark and Light themes should ignore Windows 10 setting for accent color when in high contrast mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Dão Gottwald [:dao]]

Windows 10 disables this setting and generally doesn't obey it in high contrast mode.

The Firefox default theme already handles this correctly, but Dark and Light don't.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1516556 - Dark and Light themes should ignore Windows 10 setting for accent color when in high contrast mode. r=ntim

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a2a77d23796
Dark and Light themes should ignore Windows 10 setting for accent color when in high contrast mode. r=ntim

Comment 3

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1a2a77d23796

Comment 4

[Brindusa Tot, Desktop QA]

Dão, could you please elaborate on what should we verify here?

Windows 10 version =1709 > 1703 - since apparently the accent colors got an Windows update ("Fortunately, on “Windows 10 version 1703”, Microsoft is introducing a new color pickers to set any accent color you want to see throughout the OS, and there is even an option to select a custom color when setting a solid color as background on your desktop.")

Using Fx64 2018-12-06 and Fx66 2019-01-03 :

1. Open Windows Settings/ Personalization / Colors / Windows Colors / selected and set a random weird color for accent colors using the color picker.
2. Set windows high contrast theme to High Contrast Black.
3. Opened Fx65/Nightly 66 and set Dark Theme. Compared the multi-tab close dialog.

Same behavior for both 64 & 66 for the above scenario. Not sure what accent color should affect.

Windows 10 version == 1511

1. Open Windows Settings/ Personalization / Colors / Windows Colors / select and set a random color from the accent color list. (no color picker here)
2. Set windows high contrast theme to High Contrast Black.
3. Opened Fx65/Nightly 66 and set Dark Theme. Compared the multi-tab close dialog.

Don't see any difference between the two FF versions. Also, I don't see any difference at window border - it is white for both (FF 66 and FF 65).
The only difference I see for this case is Menu Bar color: for Nightly 66 is blue (like the other windows color of other apps) and for FF 65 in black.

Comment 5

[Dão Gottwald [:dao]]

(In reply to Brindusa Tot[:brindusat] from comment #4)

Using Fx64 2018-12-06 and Fx66 2019-01-03 :

1. Open Windows Settings/ Personalization / Colors / Windows Colors / selected and set a random weird color for accent colors using the color picker.

You need to enable the option to use the accent color in title bars.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Reproduced the issue on affected Beta 65.0 (64-bit), here is a screen recording of it: https://streamable.com/lws9d
Please note that the accent color in the title bar appeared only when the Firefox Window is focused, otherwise it looks fine.

Verified - Fixed on the latest Beta 66.0b3 (64-bit) on Windows 10 x64, screen recording: https://streamable.com/cikop and https://streamable.com/wq3bx

However, for the Firefox Light theme this fix might have introduced a regression as both on High Contrast White and Black the tab titles disappear, check this: https://streamable.com/3jsyh (Note: the above videos also pointed out this issue for white/black contrast)

That is also happening only when the tab is focused as it can be observed in the case of the accent color on the affected Beta.

Dao, should I file a separate bug for this?

Comment 7

[Dão Gottwald [:dao]]

(In reply to Timea Babos from comment #6)

Dao, should I file a separate bug for this?

Yeah.

Comment 8

[Timea Cernea [:tbabos][inactive]]

Thanks Dao!
Closing this as Verified - Fixed. The mentioned issue was submitted as Bug 1523578.