1523578 - [Light theme] Tab titles are not visible in High Contrast mode with windows title bar accent color enabled

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

[Affected versions]
Firefox 67.0a1
66.0b3

[Affected platforms]
Windows 10

[Steps to reproduce]

1. Set a custom accent color from windows personalize settings
2. Enable to show accent color on title bars
3. Enable high contrast mode - black or white
4. Launch Nighlty or Beta 66
5. Open several new tabs
6. Switch the firefox theme from [Customize] to Light

[Expected result]
Firefox theme should switch to Light theme correctly

[Actual result]
Tab titles and the "+" button to open new tabs are not visible while the opened window is focused: https://streamable.com/3jsyh

[Note]
The issue was found while verifying the fix for Bug 1516556

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1523578 - In high contrast mode on Windows 10, don't override the lwtheme window background. r=ntim

Comment 2

[Tim Nguyen :ntim]

https://queue.taskcluster.net/v1/task/K55FwPqqQ9GyLz-hNjD9YQ/runs/0/artifacts/public/build/target.zip

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e27cc8c98da
In high contrast mode on Windows 10, don't override the lwtheme window background. r=ntim

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6e27cc8c98da

Comment 5

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Nightly 67.0a1 (2019-02-03) (64-bit) on Windows 10 x64.

Comment 6

[Julien Cristau [:jcristau]]

Please request uplift to beta when you get a chance.

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 9040372 [details]
Bug 1523578 - In high contrast mode on Windows 10, don't override the lwtheme window background. r=ntim

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

not sure

User impact if declined

see comment 0

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

High contrast mode + lwtheme is pretty much an edge case, and the fix is isolated to only affect that.

String changes made/needed

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9040372 [details]
Bug 1523578 - In high contrast mode on Windows 10, don't override the lwtheme window background. r=ntim

[Triage Comment]
Improves lwthemes when in Win10 high contrast mode. Approved for 66.0b6.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e31b4c03e372

Comment 11

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Beta 66.0b6 (64-bit) on Windows 10 x64.