1503022 - Dark and Light themes don't honor Windows 10 setting for accent color in title bars

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[jan]

Attachment: FirefoxWithDarkMode.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

Start Firefox 63 and have Win 10 in dark mode with highlight color checked for title bars.


Actual results:

Notice that title bar is now black with a general dark theme.


Expected results:

Either:
Firefox should just look like it did before. I don't use, nor intend to use any 'metro' apps, beside the forced upon windows settings. All my programs look bright, Firefox can just do the same.

Or:
The title should be my accent color: green.

Comment 1

[jan]

Attachment: FirefoxWithLightMode.png

Firefox in light mode honors my titlebar accent color

Comment 2

[jan]

Attachment: ColorDarkWinSettings.png

Notice the green title bar in the windows 10 settings app

Comment 3

[jan]

Attachment: ColorLightWinSettings.png

Same settings for light mode, just for completeness

Comment 4

[jan]

All programs I run are bright with my accent color as title bar color, with windows dark mode enabled, even many which came with win 10.
- File Explorer
- Notepad
- Snipping tool
- Taskmanager
- Volume Mixer
- Control Panel (for what still works in there)
- Command Prompt
- Run Dialog

I don't understand why Firefox should behave differently than the rest of the system.
If I want it to be dark I could have already select it.

I only selected dark mode in windows because this settings app gives me eye cancer in light mode.

Comment 5

[[:philipp]]

hi, you could work around that like described in https://support.mozilla.org/questions/1238727

Comment 6

[jan]

I can confirm that the workaround does its job. Would be even nicer if the config var was already there or accessible from the themes menu.
I will crosspost this workaround later from home, in a different bugreport where it was not mentioned before.
Thanks!

Comment 7

[Dão Gottwald [:dao]]

Gonna look into fixing this.

Comment 8

[matorin.qa]

I can also replicate this bug. Here is more info:

Bug ID:			        1503022
Application under test: 	Firefox Nightly
version: 			65.0a1 (2018-10-30) (64-bit)
Component:                      Titles
summary: 			Firefox title bar doesn't response to windows color settings if windows dark theme is selected. 

steps to reproduce:
  #1: Find Windows search field.
  #2: Write "color settings".
  #3: Select "Color settings" and wait till settings window is open.
  #4: In "Colors" section find "Choose your default app mode" and check "Dark" radio button.
  #5: Under "show accent color on the following surfaces" check "Title bars" box.
  #6: Under "Windows colors" select any color of your choice.
  #7: Open Firefox Nightly.
  #8: Open any other desktop app(e.g. Microsoft explorer).
  #9: Observe the difference between Firefox and the other app.

Expected result:                Firefox title bar should have color, which was chosen in the step 6.
Actual result:                  Firefox title bar has its default color.

Severity: 			Minor
Priority:			Medium
Environment:			#OS: windows 10, 64bit
Status:				UNCONFIRMED
Keywords:			nightly-community

Comment 9

[Dão Gottwald [:dao]]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=f2298c40bd27b5483fb5275c808d833e62f39c20&newProject=try&newRev=38a27a656c2acc448bc97316944a6fb7ba71c42b

Comment 10

[Dão Gottwald [:dao]]

https://screenshots.mattn.ca/compare/?oldProject=try&oldRev=c37ccd8e3c6f400052bdbbb0ff7f0ee8977c13b4&newProject=try&newRev=95457b83128666a9e83393bbd3347dd568bcb133

Comment 11

[Dão Gottwald [:dao]]

Attachment: Bug 1503022 - Refactor window and toolbar color handling and make the Dark and Light themes honor the Windows 10 accent color setting. r?ntim

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a672ddc3be9f
Refactor window and toolbar color handling and make the Dark and Light themes honor the Windows 10 accent color setting. r=ntim

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a672ddc3be9f

Comment 14

[PimpUigi]

Shouldn't the Dark Theme not get the accent color on the tabs bar though??? Cause then it's not...dark?
This is somewhat disorienting as I kept thinking my dark theme wasn't enabled on my tabs bar, and kept thinking this was a glitch with the new Nightly.

In Firefox 64 the Dark theme seems like it works right.
Show the titlebar in Dark theme, and the titlebar has the accent color. Hide the titlebar in Dark theme and the tabs bar stays Dark. That's the Dark theme.

Comment 15

[Dão Gottwald [:dao]]

Comment on attachment 9022183 [details]
Bug 1503022 - Refactor window and toolbar color handling and make the Dark and Light themes honor the Windows 10 accent color setting. r?ntim

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: bug 1368808

User impact if declined: see comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: In the Windows 10 color settings, enable both Dark mode and accent colors in title bars

List of other uplifts needed: dependencies already uplifted

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): This patch is relatively complex because I refactored some things. I could come up with a minimal patch for Beta, but that would come with its own risks, whereas the refactoring should make it easier to uplift any followups.

Baked in Nightly for about a week. The only issue I found so far is bug 1505328 and that's minor.

String changes made/needed: -

Comment 16

[Stefan [:StefanG_QA]]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0 (20181108100100)

I was able to reproduce the issue on Windows 10 x64 using the old Nightly build from 20181101220058.

The issue is verified as fixed on Windows 10 x64 using the latest Nightly build (20181108100100).

Comment 17

[PimpUigi]

Is it that I should make a new bug report that says "Dark Theme tabs bar should not inherit Windows 10 Accent Color" ?

Comment 18

[PimpUigi]

Would be nice if there were a 3rd theme that had the tabs bar as Acrylic and the active tab + Location Bar + Bookmarks Bar all honoring the Windows 10 accent.

Comment 19

[Dão Gottwald [:dao]]

Comment on attachment 9022183 [details]
Bug 1503022 - Refactor window and toolbar color handling and make the Dark and Light themes honor the Windows 10 accent color setting. r?ntim

Cancelling uplift request because of bug 1506114, which I'm working on but is probably going to be too risky to uplift.