Setup WNP for users coming from <65.0 and receiving the 65.0 release

RESOLVED FIXED

Status

enhancement
--
major
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: erenaud, Unassigned)

Tracking

({leave-open})

unspecified
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

()

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

5 months ago

+++ This bug was initially created as a clone of Bug #1508494 +++

Request is to have the product point to the /whatsnew page in the Firefox 65.0 release and show it (WNP).

  • We still need to include id and zh-TW independently, because they have their own template.

  • en-GB needs to be included by activating the file manuallyen-US to show up in the URL, you need Peiying to manually activate the file.

  • No string changes will occur, only the removal of one or more (no new content)

(In reply to Eric Renaud [:erenaud] from comment #0)

  • No string changes will occur, only the removal of one or more (no new content)

Hi Eric,

I think it's been decided that we are stripping “Here’s What’s New” from the content. I suppose that means we need to re-localize the list of locales and then provide the finalized list for 64.0 by Jan 18th? As per: https://docs.google.com/document/d/18EvnR23dUdHSnJtpGdZ7fjxpEWHhfOSv4dEohdXGjTI

l10n couldn't attend this morning's wnp meeting so I just want to make sure it's on their radar.

Flags: needinfo?(erenaud)
Comment hidden (off-topic)
Reporter

Updated

5 months ago
Flags: needinfo?(erenaud)
Posted file List of locales for RelEng (obsolete) —

Complete locales (51):
ar, az, be, cak, cs, cy, da, de, dsb, en-CA, en-GB, en-US, es-AR, es-CL, es-MX, et, fr, fy-NL, gl, gn, gu-IN, hi-IN, hsb, hu, ia, id, it, ka, ko, lij, lt, ms, nb-NO, nl, nn-NO, pl, pt-BR, pt-PT, rm, ro, ru, sk, sl, sq, sv-SE, th, tr, uk, vi, zh-CN, zh-TW

Switching to copy the list as attachment, and hiding the original comment, since it makes the bug quite unreadable.

Comment 4

5 months ago
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28720440e190
Update WNP with locales for 65; r=flod a=whats-new

Grafted to beta too: https://hg.mozilla.org/releases/mozilla-beta/rev/5e7a2d9c3127

It'll ride the trains for Monday's mergeduty.

Comment 6

5 months ago
bugherder
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED

Re-opening this until the work is done in Balrog as well.
I've landed the WNP patch on inbound + beta so it's riding the trains to release on Monday.
Thanks Sheriffs for merging this to central.

Status: RESOLVED → REOPENED
Keywords: leave-open
Resolution: FIXED → ---

The 65 WNP is now live in production: https://www.mozilla.org/en-US/firefox/65.0/whatsnew/

Hello, we are testing now WNP on release-localtest and we saw that a few locales that are not in the list from comment 3 are still receiving WNP. example (ja, he, es-ES etc.) Is this something that should happen?

Flags: needinfo?(erenaud)

That's my fault, unfortunately. I updated the script to generate the list of locaels for YAML, and picked the wrong variable (list of locales in release, not list of locales with the page translated).

Flags: needinfo?(erenaud)
Attachment #9037141 - Attachment is obsolete: true

Note: the attachment has 52 locales, since es-ES completed the page in the meantime (compared to comment 3). Since we're re-landing the list, worth taking it. Sorry for the issue.

Comment 12

5 months ago
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/55c218c9489b
Fix/update WNP with locales for 65; r=flod a=whats-new

(In reply to Francesco Lodolo [:flod] from comment #10)

Created attachment 9038496 [details]
Correct list of locales

That's my fault, unfortunately. I updated the script to generate the list of locaels for YAML, and picked the wrong variable (list of locales in release, not list of locales with the page translated).

No worries, I should've double-checked before landing as well so we can share the blame ;-)

I landed the correct WNP list on inbound (which will eventually get to central and beta this week by normal Sheriffs process) and then to release here - https://hg.mozilla.org/releases/mozilla-release/rev/f6e47b143718.

Good job @Bogdan_Maris for spotting this!

To close the loop, RC2 will be triggered tomorrow (Thursday) and tested by QA on Friday so that should automatically pick up the correct WNP list.

This worked smooth so I think it's safe to close this.

Status: REOPENED → RESOLVED
Closed: 5 months ago4 months ago
Resolution: --- → FIXED
No longer blocks: 1525081
See Also: → 1523699
You need to log in before you can comment on or make changes to this bug.