Enable picture caching
Categories
(Core :: Graphics: WebRender, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | unaffected |
firefox65 | --- | unaffected |
firefox66 | --- | fixed |
People
(Reporter: gw, Assigned: gw)
References
Details
(Keywords: feature)
Attachments
(2 files)
There are still some performance tidy ups, and at least one (seemingly) very rare known visual bug.
But I think we should enable it by default on nightly, and see what breaks and what effect it has on telemetry numbers. We can always disable it if there is any major breakage or performance regressions encountered.
We should make sure the most recent patches in WR (https://github.com/servo/webrender/pull/3482) have landed in m-c before enabling - there is one patch open for review that still needs to be merged first.
I'm not sure the best way to enable it - would flipping the default value of the picture caching preference be right?
Assignee | ||
Comment 1•6 years ago
|
||
Though, in light of https://bugzilla.mozilla.org/show_bug.cgi?id=1518406 and https://bugzilla.mozilla.org/show_bug.cgi?id=1518407 being reported, perhaps I should investigate those and add the functionality to skip caching tiles that are constantly changing before enabling? That should be a minor change, < 0.5 days work.
Updated•6 years ago
|
Assignee | ||
Comment 2•6 years ago
|
||
I opened a pull request to only start caching tiles when they have had the same content for > 2 frames, which should (hopefully) resolve the issues reported above, although I can't reproduce a regression of that significance.
So, the pending patches we need to get into m-c before enabling picture caching are:
https://github.com/servo/webrender/pull/3487
https://github.com/servo/webrender/pull/3482
Comment 3•6 years ago
|
||
(In reply to Glenn Watson [:gw] from comment #0)
I'm not sure the best way to enable it - would flipping the default value of the picture caching preference be right?
Yeah, changing it at https://searchfox.org/mozilla-central/rev/c3ebaf6de2d481c262c04bb9657eaf76bf47e2ac/modules/libpref/init/all.js#960 would be the way to do it.
Updated•6 years ago
|
Comment 4•6 years ago
|
||
Comment 6•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Comment 7•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/340d5146c405
I backed this out for the talos regreesion, and because we suspect it of causing telemetry regressions.
There are more fixes in-flight, so we'll land it again early next week!
Updated•6 years ago
|
Comment 8•6 years ago
|
||
Unassigning since I will be away when we want to reland this.
Assignee | ||
Comment 9•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 10•6 years ago
|
||
Updated•6 years ago
|
Comment 11•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Description
•